[release/9.0] [ci] Don't run tests on internal pipeline builds - #6467
#6467Merged
joperezr merged 1 commit intoOct 24, 2024
release/9.0microsoft/aspire:release/9.0from
backport/pr-6413-to-release/9.0microsoft/aspire:backport/pr-6413-to-release/9.0Copy head branch name to clipboard
Merged
[release/9.0] [ci] Don't run tests on internal pipeline builds#6467joperezr merged 1 commit intorelease/9.0microsoft/aspire:release/9.0from backport/pr-6413-to-release/9.0microsoft/aspire:backport/pr-6413-to-release/9.0Copy head branch name to clipboard
joperezr merged 1 commit into
release/9.0microsoft/aspire:release/9.0from
backport/pr-6413-to-release/9.0microsoft/aspire:backport/pr-6413-to-release/9.0Copy head branch name to clipboard
Conversation
Member
|
This is needed in order to be able to build internally with stable versions of the rest of .NET, as those require special infrastructure. |
joperezr
approved these changes
Oct 23, 2024
Member
|
Merging as tell mode as we need this to get a coherent build out. |
joperezr
added a commit
to joperezr/aspire
that referenced
this pull request
Nov 13, 2024
#### AI description (iteration 1) #### PR Classification Merge branch `release/9.0` into `internal/release/9.0` to integrate recent changes and address specific work items. #### PR Summary This pull request integrates changes from the `release/9.0` branch into `internal/release/9.0`, addressing several work items related to Azure storage and network isolation. - `/tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs`: Added a new test `ConfigureCustomDomainsMutatesIngress` to validate custom domain configuration for Azure Container Apps. - `/src/Aspire.Hosting.Azure.AppContainers/ContainerAppExtensions.cs`: Introduced a new extension method `ConfigureCustomDomain` to simplify the process of assigning custom domains to Azure Container Apps. Related work items: microsoft#6368, microsoft#6391, microsoft#6433, microsoft#6458, microsoft#6467
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6413 to release/9.0
/cc @joperezr @radical
Customer Impact
Testing
Risk
Regression?
Microsoft Reviewers: Open in CodeFlow