Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[ci] Don't run tests on internal pipeline builds - #6413

#6413
Merged
joperezr merged 1 commit into
microsoft:mainmicrosoft/aspire:mainfrom
radical:no-tests-internalradical/aspire:no-tests-internalCopy head branch name to clipboard
Oct 23, 2024
Merged

[ci] Don't run tests on internal pipeline builds#6413
joperezr merged 1 commit into
microsoft:mainmicrosoft/aspire:mainfrom
radical:no-tests-internalradical/aspire:no-tests-internalCopy head branch name to clipboard

Conversation

@radical

@radical radical commented Oct 21, 2024

Copy link
Copy Markdown
Member

Description

Tests for main are run on the public pipeline, and are not needed for the internal one where we essentially build the packages to be published.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@radical
radical requested review from RussKie, eerhardt and joperezr and removed request for RussKie October 21, 2024 17:56
@radical

radical commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

@radical radical added the area-engineering-systems infrastructure helix infra engineering repo stuff label Oct 21, 2024
@radical

radical commented Oct 23, 2024

Copy link
Copy Markdown
Member Author

@joperezr this one is ready for review.

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Comment thread eng/pipelines/templates/BuildAndTest.yml
@joperezr

Copy link
Copy Markdown
Member

Merging and backporting this to release/9.0 as it is needed for the internal builds too. Thanks @radical!

@joperezr
joperezr merged commit f3a410d into microsoft:main Oct 23, 2024
@radical
radical deleted the no-tests-internal branch October 23, 2024 21:29
@joperezr

Copy link
Copy Markdown
Member

/backport to release/9.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11488497385

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.