Clean harness option loading#4383
Merged
mhegazy merged 19 commits intoSep 15, 2015
mastermicrosoft/TypeScript:masterfrom
cleanHarnessOptionLoadingmicrosoft/TypeScript:cleanHarnessOptionLoadingCopy head branch name to clipboard
Merged
Clean harness option loading#4383mhegazy merged 19 commits intomastermicrosoft/TypeScript:masterfrom cleanHarnessOptionLoadingmicrosoft/TypeScript:cleanHarnessOptionLoadingCopy head branch name to clipboard
mhegazy merged 19 commits into
mastermicrosoft/TypeScript:masterfrom
cleanHarnessOptionLoadingmicrosoft/TypeScript:cleanHarnessOptionLoadingCopy head branch name to clipboard
Conversation
Conflicts: src/harness/fourslash.ts src/harness/harness.ts
…instead of doing it explicitlly
Contributor
Author
|
So i have moved to just use the commandlineParser defintions instead of parsing each string into an enum. this way any compiler option added is a valid harness option. |
Member
|
👍 |
Conflicts: src/harness/harness.ts
…tions do not take precedance any longer.
Conflicts: tests/cases/compiler/pinnedComments1.ts
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following up on the conversation in #4371 (comment), this consolidates all compiler option parsing in one place in the harness.