Emit tsx files correctly in getEmitOutput calls#4371
Emit tsx files correctly in getEmitOutput calls#4371
Conversation
There was a problem hiding this comment.
This looks so easy to screw up (and I have, and I thought I removed these (or something like these lists) for that reason). Why not split metadataOptionNames into two maps, merge them into metadataOptionNames at runtime, and create these lists out of the maps?
There was a problem hiding this comment.
i thought you will remove this as part of the test update.. i can remove them all, but will do that in a different change.. actually they are repeated twice, once in harness and once in fourslash, and each has a map and a switch, and each has a slightly different implantation for comparing and setting the values.
There was a problem hiding this comment.
It's okay, I'll take care of it tomorrow.
|
@DanielRosenwasser any other comments for this change? |
|
Just this one and then I think we'll be good. |
Emit tsx files correctly in getEmitOutput calls
When using
--jsx preservewe were setting the extension of any file in Compile-on-Save scenarios to.jsxf there is at least one file that has.tsxextension. this does not match the command line compilation, which decides the emitted file extension on a file-per-file basis. fixing and adding a test.