Add regressions for conditional types that affect parameter variance#30146
Merged
weswigham merged 1 commit intoMar 1, 2019
microsoft:mastermicrosoft/TypeScript:masterfrom
jack-williams:add-regression-for-conditional-type-variancejack-williams/TypeScript:add-regression-for-conditional-type-varianceCopy head branch name to clipboard
Merged
Add regressions for conditional types that affect parameter variance#30146weswigham merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom jack-williams:add-regression-for-conditional-type-variancejack-williams/TypeScript:add-regression-for-conditional-type-varianceCopy head branch name to clipboard
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
jack-williams:add-regression-for-conditional-type-variancejack-williams/TypeScript:add-regression-for-conditional-type-varianceCopy head branch name to clipboard
Conversation
matthargett
approved these changes
Feb 28, 2019
matthargett
left a comment
There was a problem hiding this comment.
It's great to see regression tests for fixed bugs being added!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regressions for #27697 in combination with #27804.