Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make the assignability rule for conditional types require the check types and distributivity to be identical.#27697

Merged
RyanCavanaugh merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
mattmccutchen:issue-27118mattmccutchen/TypeScript:issue-27118Copy head branch name to clipboard
Feb 11, 2019
Merged

Make the assignability rule for conditional types require the check types and distributivity to be identical.#27697
RyanCavanaugh merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
mattmccutchen:issue-27118mattmccutchen/TypeScript:issue-27118Copy head branch name to clipboard

Conversation

@mattmccutchen

Copy link
Copy Markdown
Contributor

Fixes #27118.

@mattmccutchen

mattmccutchen commented Oct 10, 2018

Copy link
Copy Markdown
Contributor Author

@typescript-bot test this

I'm not even worthy of a rejection notice from the typescript-bot. ☹️

@weswigham

Copy link
Copy Markdown
Member

@typescript-bot test this

He only responds to a MS org member/project owner's hails.

@typescript-bot

typescript-bot commented Oct 17, 2018

Copy link
Copy Markdown
Contributor

Heya @weswigham, I've started to run the extended test suite on this PR at bc9b6d5. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh

Copy link
Copy Markdown
Member

@typescript-bot test this again

@typescript-bot

typescript-bot commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at bc9b6d5. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh RyanCavanaugh self-assigned this Jan 24, 2019
@mattmccutchen

Copy link
Copy Markdown
Contributor Author

Updated to master. This should remove the unrelated RWC differences.

@RyanCavanaugh

Copy link
Copy Markdown
Member

@typescript-bot test this

@typescript-bot

typescript-bot commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 1aca1dd. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh

Copy link
Copy Markdown
Member

RWC is green! 🎉

@RyanCavanaugh RyanCavanaugh merged commit 2dfb620 into microsoft:master Feb 11, 2019
sandersn added a commit that referenced this pull request Feb 27, 2019
This reverts commit 2dfb620, reversing
changes made to bbf559b.
sandersn added a commit that referenced this pull request Feb 27, 2019
…riance

Revert "Merge pull request #27697 from mattmccutchen/issue-27118"
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.