Revert change to canUseEvents in IoSessionOptions#22791
Merged
1 commit merged intoMar 22, 2018
Merged
Revert change to canUseEvents in IoSessionOptions#227911 commit merged into
canUseEvents in IoSessionOptions#227911 commit merged into
Conversation
mhegazy
approved these changes
Mar 22, 2018
Member
|
amcasey
approved these changes
Mar 22, 2018
Contributor
eventPort is rely a VS construct to avoid needing to handle async events on the same io channel as sync messages
yes.. probably.. |
Author
That option is public though. |
Contributor
|
humm.. @aozgaa looked into this a while back.. i think he might know more. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22790 (tested in a local build with vscode)
In #22591 this was changed from hardcoded
truetoeventPort !== undefined.