Delete IoSessionOptions#22591
Merged
Merged
Delete IoSessionOptions#22591
Conversation
Member
Author
|
Alternatively, we could actually use the properties of IoSessionOptions, but that has the disadvantage of being error-prone (as demonstrated by the current state). |
ghost
approved these changes
Mar 15, 2018
sheetalkamat
requested changes
Mar 15, 2018
sheetalkamat
left a comment
Member
There was a problem hiding this comment.
This has changes from suppressProjectEvents (PR: #22590) which shouldnt be in this PR.
Member
Author
|
@sheetalkamat Correct, I will not merge this until #22590 is sorted out. |
Member
|
can you please fix #22607 as well as part of this. Thank you. |
RyanCavanaugh
approved these changes
Mar 15, 2018
Many of the operations were unused because the values were being accessed directly from the enclosing scope.
Member
Author
|
@sheetalkamat, I created #22776 for #22607. |
This was referenced Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the options were unused because the values were being accessed directly from the enclosing scope.
The first commit is #22590.