chore: update k8s libs to 1.24#577
chore: update k8s libs to 1.24#577
Conversation
| } | ||
|
|
||
| o.DryRunVerifier = resource.NewDryRunVerifier(o.DynamicClient, o.DiscoveryClient) | ||
| o.DryRunVerifier = resource.NewQueryParamVerifier(o.DynamicClient, f.OpenAPIGetter(), resource.QueryParamDryRun) |
There was a problem hiding this comment.
This change is similar to kubernetes/kubectl@7e68149
|
/retest |
| } | ||
| if t.SelfLink != "" { | ||
| u.SetSelfLink(t.SelfLink) | ||
| if t.SelfLink != "" { // nolint:staticcheck |
There was a problem hiding this comment.
SA1019: t.SelfLink is deprecated: selfLink is a legacy read-only field that is no longer populated by the system. +optional (staticcheck)
This field is deprecated. Skipping it.
|
/cc @mortent |
|
/cc @karlkfi |
|
This PR will fix the go mod conflicts we had in kpt and porch, and it is critical for all the users who use both KRM functions (new sdk) and cli-utils! |
|
Historically we haven't taken new k8s versions until they're fully released and can be picked up by the known downstream clients (kpt, Config Sync, GitLab Agent). I'm not sure how to handle a release candidate. My best advice would be to temporarily vendor cli-utils with your changes into your downstream client, until cli-util is updated with the change and a new release is cut. |
|
Rebased. PTAL |
|
/hold Blocking until #572 is merged. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, mengqiy, mortent The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
We want to bump the k8s dependencies, since when want to import a newer kyaml version in kpt. This kyaml version is only compatible with k8s v0.24+ due import path change in kubernetes/kube-openapi#285.