Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

update kustomize dependencies#3026

Closed
natasha41575 wants to merge 1 commit into
kptdev:mainkptdev/kpt:mainfrom
natasha41575:updatenatasha41575/kpt:updateCopy head branch name to clipboard
Closed

update kustomize dependencies#3026
natasha41575 wants to merge 1 commit into
kptdev:mainkptdev/kpt:mainfrom
natasha41575:updatenatasha41575/kpt:updateCopy head branch name to clipboard

Conversation

@natasha41575

Copy link
Copy Markdown
Contributor

Pick up the performance boost from kubernetes-sigs/kustomize#4568

@natasha41575
natasha41575 requested review from droot and mengqiy April 19, 2022 22:11
@natasha41575

natasha41575 commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

I found https://github.com/kubernetes/client-go/issues/1075, which describes the issue that we are getting here.

The problem is that github.com/googleapis/gnostic was renamed to github.com/google/gnostic. Different dependencies are pulling in different names, so we get a bunch of errors because Go thinks that types from github.com/google/gnostic aren't the same as github.com/googleapis/gnostic

Ideally we would be able to upgrade all the dependencies to make this work, but it appears that we still have some (like k8s.io/cli-runtime) that still depend on the old name, while the newest kube-openapi depends on the new name (we need to upgrade kube-openapi to get the performance boost) - making them incompatible.

I'm not sure if there is any solution for this besides a replace statement.

Some other context: we had to make this gnostic name upgrade change in kustomize due to integration with kubectl: kubernetes-sigs/kustomize#4538

@yuwenma

yuwenma commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

hit the same issue when bumping the set-namespace in porch #3028

@natasha41575 shall we bump the kyaml in all functions (set-namespace, starlark, apply-replacement) and sdk?

@mengqiy

mengqiy commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

We need kubernetes-sigs/cli-utils#577

@mengqiy mengqiy closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.