Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

update functional tests for newer llama_cpp_python version #788

Copy link
Copy link
@xukai92

Description

@xukai92
Issue body actions

function tests in recent PRs (#772, #776, #777, #778, #780, #784) failed because of a llama_cpp_python version upgrade.

  • we need llama_cpp_python==0.2.55 to make the current functional test passes, which doesn't work for 0.2.58.
  • with 0.2.58, lab serve doesn't return the same different error to client side therefore https://github.com/instruct-lab/cli/blob/main/scripts/functional-tests.sh#L114-L120 fails
    • with a quick check, it seems that there is some error on the llama_cpp_python side that the expected message doesn't pass to the client side. so maybe this will be fixed in the future

I think it's fair to either

  • fix the version to 0.2.55, or
  • disable that particular check for now
Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.