fix: Suppress valid message on diff --quiet#784
Closed
rafvasq wants to merge 3 commits intoinstructlab:maininstructlab/instructlab:mainfrom
rafvasq:fix-diff-quietCopy head branch name to clipboard
Closed
fix: Suppress valid message on diff --quiet#784rafvasq wants to merge 3 commits intoinstructlab:maininstructlab/instructlab:mainfrom rafvasq:fix-diff-quietCopy head branch name to clipboard
rafvasq wants to merge 3 commits intoinstructlab:maininstructlab/instructlab:mainfrom
rafvasq:fix-diff-quietCopy head branch name to clipboard
Conversation
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
bjhargrave
suggested changes
Apr 3, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
bjhargrave
approved these changes
Apr 3, 2024
Contributor
jgato
pushed a commit
to jgato/instructlab
that referenced
this pull request
Jun 21, 2024
…#784) We include the workflow file in the trigger to test when a PR modifies the workflow. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Related to #732 and #756.
Description of your changes:
If the taxonomy is valid,
ilab diff --quietoutputs a "taxonomy is valid" message, but not when it's invalid. This flag shouldn't output anything in either case as per #732. Related flaky tests also updated as pointed out by @bjhargrave.