pin llama_cpp_python to 0.2.55#789
Merged
xukai92 merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom Apr 4, 2024
anik120:fix-function-test-llama-depanik120/lab-cli:fix-function-test-llama-depCopy head branch name to clipboard
Merged
pin llama_cpp_python to 0.2.55#789xukai92 merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom anik120:fix-function-test-llama-depanik120/lab-cli:fix-function-test-llama-depCopy head branch name to clipboard
xukai92 merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
anik120:fix-function-test-llama-depanik120/lab-cli:fix-function-test-llama-depCopy head branch name to clipboard
Conversation
anik120
commented
Apr 4, 2024
requirements.txt
Outdated
| llama_cpp_python[server]>=0.2.55,<0.3.0; sys_platform != 'darwin' | ||
| # pin macOS version, lift restriction after testing >=0.2.58 | ||
| # see https://github.com/abetlen/llama-cpp-python/issues/1286 | ||
| llama_cpp_python[server]==0.2.55; sys_platform == 'darwin' |
Contributor
Author
There was a problem hiding this comment.
@xukai92 looks like this was already in here hah
anik120
commented
Apr 4, 2024
| httpx | ||
| llama_cpp_python[server]>=0.2.55,<0.3.0; sys_platform != 'darwin' | ||
| # pin macOS version, lift restriction after testing >=0.2.58 | ||
| # see https://github.com/abetlen/llama-cpp-python/issues/1286 |
Contributor
Author
There was a problem hiding this comment.
And looks like we ran into this before too
Member
There was a problem hiding this comment.
yeah, we run into a related issue before. i can't remember what was it but maybe you can git blame to find it.
Contributor
Author
There was a problem hiding this comment.
Yea I did that, turns out it was the exact same issue that we've been running into, only folks running into this were running it on their Macs, so fixed it only for macOS.
a0fa14c to
d86bf01
Compare
xukai92
requested changes
Apr 4, 2024
Closes #788 Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
d86bf01 to
4d7ec33
Compare
xukai92
approved these changes
Apr 4, 2024
This was referenced Apr 4, 2024
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Resolves #788
Description of your changes: