Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed in php 8.6 (master)#408

Open
k0d3r1s wants to merge 1 commit into
igbinary:masterigbinary/igbinary:masterfrom
fork-php:zval_ptr_dtor_nogcfork-php/igbinary:zval_ptr_dtor_nogcCopy head branch name to clipboard
Open

The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed in php 8.6 (master)#408
k0d3r1s wants to merge 1 commit into
igbinary:masterigbinary/igbinary:masterfrom
fork-php:zval_ptr_dtor_nogcfork-php/igbinary:zval_ptr_dtor_nogcCopy head branch name to clipboard

Conversation

@k0d3r1s

@k0d3r1s k0d3r1s commented Dec 4, 2025

Copy link
Copy Markdown

Hi. Tried building against php master branch and this issue jumped out.
php UPGRADING.INTERNALS says: "The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed. Call zval_ptr_dtor_nogc() directly instead.".
So as this is purely removed alias, this seems to be a trivial fix

@k0d3r1s
The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed
2e07888 
Call zval_ptr_dtor_nogc() directly instead
@tricky

tricky commented Dec 4, 2025

Copy link
Copy Markdown
Member

Well that failed spectacularly. :)

@k0d3r1s

k0d3r1s commented Dec 6, 2025

Copy link
Copy Markdown
Author

@tricky none of failures seems to be related to my changes. looks like missing slash in action somewhere, at least for linux builds

@andrew-demb

andrew-demb commented Dec 6, 2025 •
edited
Loading

Copy link
Copy Markdown

It is an invalid redirect location got from secure.php.net for the distribution archive

@tricky

tricky commented Dec 6, 2025

Copy link
Copy Markdown
Member

Yes, hence the smiley. :)

@madmajestro madmajestro mentioned this pull request Mar 3, 2026
Merged
@andypost

andypost commented Apr 25, 2026

Copy link
Copy Markdown

btw this function was added in PHP 7.3 php/php-src@ebd1f5a#diff-aaa3174af361a8e16850162bbd86ff5aaf7340f1511d5c36db1a417798d0897eR34

@madmajestro

madmajestro commented May 5, 2026

Copy link
Copy Markdown

@andypost
Yes, you are right, but before that commit, a function with the name _zval_ptr_dtor_nogc() existed and according to it a define which mapped zval_ptr_dtor_nogc() to _zval_ptr_dtor_nogc(). This means that zval_ptr_dtor_nogc() was already available before PHP 7.0 and that this PR will work for all old PHP 7.x versions supported by igbinary.

@andypost

andypost commented May 5, 2026

Copy link
Copy Markdown

@madmajestro exactly since 7.0 the function introduced, ref php/php-src@9e753531842

@andypost andypost mentioned this pull request May 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@k0d3r1s @tricky @andrew-demb @andypost @madmajestro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.