Fix Windows CI and build pipelines for PHP >= 8.1#412
Merged
tricky merged 4 commits intoMay 5, 2026
igbinary:masterigbinary/igbinary:masterfrom
madmajestro:fix-windows-pipelines-for-new-php-versionsmadmajestro/igbinary:fix-windows-pipelines-for-new-php-versionsCopy head branch name to clipboard
Merged
Fix Windows CI and build pipelines for PHP >= 8.1#412tricky merged 4 commits intoigbinary:masterigbinary/igbinary:masterfrom madmajestro:fix-windows-pipelines-for-new-php-versionsmadmajestro/igbinary:fix-windows-pipelines-for-new-php-versionsCopy head branch name to clipboard
tricky merged 4 commits into
igbinary:masterigbinary/igbinary:masterfrom
madmajestro:fix-windows-pipelines-for-new-php-versionsmadmajestro/igbinary:fix-windows-pipelines-for-new-php-versionsCopy head branch name to clipboard
Conversation
Author
|
Currently, all Windows pipelines for PHP >= 8.1 will fail. Therefore, this pull request should be merged before attempting to start pipelines for other pull requests. |
Author
|
I added a fix for various curl download errors i saw during testing with my igbinary repository clone. The pipeline of #408 should succeed now. |
1427227 to
8db330e
Compare
Running Windows pipelines for PHP >= 8.1 failed with setup-php-sdk@v0.11 due to TLS issues. Using setup-php-sdk@v0.12 resolves this by explicitly enabling TLS 1.2 and TLS 1.3.
The older curl versions with http2 support (7.64 - 7.74) seem to start too many parallel http2 streams, which causes the server to terminate the connections with 503 http errors. Limiting curl to http1.1 resolves the problem. The download URL has also been updated.
8db330e to
1798cf8
Compare
Author
|
Friendly Ping |
GitHub action checkout@v4 / v2 uses Node.js 20, which is deprecated and will be removed from the runner image later this year. It is replaced by checkout@v6, which uses Node.js 24.
Author
|
Friendly Ping |
Author
|
@phadej @pierrejoye @tricky @TysonAndre It seems you're all very busy and have little time to maintain Igbinary at the moment (which is perfectly fine). I would like to offer my help maintaining the project and to get more involved. As a reference i can mention my work with krakjoe/apcu, which is somewhat related to igbinary. Is there any interest in my help? Who should I contact / talk to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Windows pipelines for PHP >= 8.1 failed with setup-php-sdk@v0.11 due to TLS issues. Using setup-php-sdk@v0.12 resolves this by explicitly enabling TLS 1.2 and TLS 1.3. Additionally, download failures were fixed by limiting curl to use HTTP 1.1 and GitHub actions/checkout are updated to v6 due to the Node.js 20 deprecation.