Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: improve timeout structure#819

Merged
daniel-sanche merged 227 commits into
googleapis:v3googleapis/python-bigtable:v3from
daniel-sanche:improve-timeoutsdaniel-sanche/python-bigtable:improve-timeoutsCopy head branch name to clipboard
Jun 29, 2023
Merged

feat: improve timeout structure#819
daniel-sanche merged 227 commits into
googleapis:v3googleapis/python-bigtable:v3from
daniel-sanche:improve-timeoutsdaniel-sanche/python-bigtable:improve-timeoutsCopy head branch name to clipboard

Conversation

@daniel-sanche

@daniel-sanche daniel-sanche commented Jun 27, 2023

Copy link
Copy Markdown
Contributor
  • renamed per_request_timeout to attempt_timeout
  • previously, we just had default_operation_timeout and default_per_request_timeout values configurable at the table level. Now, have different defaults for read_rows and mutate_rows
  • centralized timeout validation into a new helper function
  • improved some docstrings related to timeouts

Fixes #782

gcf-owl-bot Bot and others added 30 commits March 16, 2023 08:01
…gleapis#750)

Source-Link: googleapis/synthtool@92006bb
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b2ab4b0a0ae2907e812c209198a74e0898afcb04
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jun 27, 2023
gcf-owl-bot Bot and others added 2 commits June 28, 2023 03:44
Source-Link: googleapis/synthtool@909573c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jun 28, 2023
@daniel-sanche daniel-sanche changed the title [DRAFT] feat: improve timeout structure feat: improve timeout structure Jun 28, 2023
@daniel-sanche daniel-sanche marked this pull request as ready for review June 28, 2023 19:18
@daniel-sanche daniel-sanche requested review from a team June 28, 2023 19:18
Comment thread google/cloud/bigtable/data/_async/_mutate_rows.py Outdated
Comment thread google/cloud/bigtable/data/_async/_mutate_rows.py Outdated
Comment thread google/cloud/bigtable/data/_async/client.py Outdated
Comment thread google/cloud/bigtable/data/_async/client.py
Comment thread google/cloud/bigtable/data/_async/client.py
Comment thread google/cloud/bigtable/data/_async/mutations_batcher.py Outdated
Comment thread google/cloud/bigtable/data/_async/mutations_batcher.py
Comment thread google/cloud/bigtable/data/_async/mutations_batcher.py Outdated
daniel-sanche and others added 5 commits June 28, 2023 22:53
Co-authored-by: Mattie Fu <mattiefu@google.com>
Co-authored-by: Mattie Fu <mattiefu@google.com>
Comment thread google/cloud/bigtable/data/_async/client.py
Comment thread google/cloud/bigtable/data/_async/client.py
Comment thread google/cloud/bigtable/data/_async/client.py
@daniel-sanche daniel-sanche merged commit 07438ca into googleapis:v3 Jun 29, 2023
daniel-sanche added a commit that referenced this pull request Feb 5, 2024
* feat: add new v3.0.0 API skeleton (#745)

* feat: improve rows filters (#751)

* feat: read rows query model class (#752)

* feat: implement row and cell model classes (#753)

* feat: add pooled grpc transport (#748)

* feat: implement read_rows (#762)

* feat: implement mutate rows (#769)

* feat: literal value filter (#767)

* feat: row_exists and read_row (#778)

* feat: read_modify_write and check_and_mutate_row (#780)

* feat: sharded read rows (#766)

* feat: ping and warm with metadata (#810)

* feat: mutate rows batching (#770)

* chore: restructure module paths (#816)

* feat: improve timeout structure (#819)

* fix: api errors apply to all bulk mutations

* chore: reduce public api surface (#820)

* feat: improve error group tracebacks on < py11 (#825)

* feat: optimize read_rows (#852)

* chore: add user agent suffix (#842)

* feat: optimize retries (#854)

* feat: add test proxy (#836)

* chore(tests): add conformance tests to CI for v3 (#870)

* chore(tests): turn off fast fail for conformance tets (#882)

* feat: add TABLE_DEFAULTS enum for table method arguments (#880)

* fix: pass None for retry in gapic calls (#881)

* feat: replace internal dictionaries with protos in gapic calls (#875)

* chore: optimize gapic calls (#863)

* feat: expose retryable error codes to users (#879)

* chore: update api_core submodule (#897)

* chore: merge main into experimental_v3 (#900)

* chore: pin conformance tests to v0.0.2 (#903)

* fix: bulk mutation eventual success (#909)

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.