Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

fix: Update max_instances default to reflect actual value#2302

Merged
jialuoo merged 1 commit into
maingoogleapis/python-bigquery-dataframes:mainfrom
fix-rf-max-instancegoogleapis/python-bigquery-dataframes:fix-rf-max-instanceCopy head branch name to clipboard
Dec 2, 2025
Merged

fix: Update max_instances default to reflect actual value#2302
jialuoo merged 1 commit into
maingoogleapis/python-bigquery-dataframes:mainfrom
fix-rf-max-instancegoogleapis/python-bigquery-dataframes:fix-rf-max-instanceCopy head branch name to clipboard

Conversation

@jialuoo

@jialuoo jialuoo commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

The default maximum instances for cloud functions is 100, not 0. Updated the expected_max_instances in the parametrize decorator to 100 for the 'no-set' and 'set-None' test cases to accurately reflect the runtime behavior.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/465212379 🦕

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 2, 2025
@jialuoo jialuoo requested a review from GarrettWu December 2, 2025 00:24
@jialuoo jialuoo marked this pull request as ready for review December 2, 2025 00:24
@jialuoo jialuoo requested review from a team December 2, 2025 00:24
@jialuoo jialuoo merged commit 4489687 into main Dec 2, 2025
21 of 25 checks passed
@jialuoo jialuoo deleted the fix-rf-max-instance branch December 2, 2025 01:24
@GarrettWu GarrettWu mentioned this pull request Dec 3, 2025
GarrettWu added a commit that referenced this pull request Dec 3, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>bigframes: 2.30.0</summary>

##
[2.30.0](v2.29.0...v2.30.0)
(2025-12-03)

### Features

* Support mixed scalar-analytic expressions (#2239)
([20ab469](20ab469d))

* Allow drop_duplicates over unordered dataframe (#2303)
([52665fa](52665fa5))

* Preserve source names better for more readable sql (#2243)
([64995d6](64995d65))

* use end user credentials for `bigframes.bigquery.ai` functions when
`connection_id` is not present (#2272)
([7c062a6](7c062a68))

* pivot_table supports fill_value arg (#2257)
([8f490e6](8f490e68))

* Support builtins funcs for df.agg (#2256)
([956a5b0](956a5b00))

* add bigquery.json_keys (#2286)
([b487cf1](b487cf1f))

* Add agg/aggregate methods to windows (#2288)
([c4cb39d](c4cb39dc))

* Add bigframes.pandas.crosstab (#2231)
([c62e553](c62e5535))

* Implement single-column sorting for interactive table widget (#2255)
([d1ecc61](d1ecc61b))

### Bug Fixes

* Pass credentials properly for read api instantiation (#2280)
([3e3fe25](3e3fe259))

* Update max_instances default to reflect actual value (#2302)
([4489687](4489687e))

* Improve Anywidget pagination and display for unknown row counts
(#2258)
([508deae](508deae5))

* Fix issue with stream upload batch size upload limit (#2290)
([6cdf64b](6cdf64b0))

* calling info() on empty dataframes no longer leads to errors (#2267)
([95a83f7](95a83f77))

* do not warn with DefaultIndexWarning in partial ordering mode (#2230)
([cc2dbae](cc2dbae6))

### Documentation

* update docs and tests for Gemini 2.5 models (#2279)
([08c0c0c](08c0c0c8))

* Add Google Analytics configuration to conf.py (#2301)
([0b266da](0b266da1))

* fix LogisticRegression docs rendering (#2295)
([32e5313](32e53134))

* update API reference to new `dataframes.bigquery.dev` location (#2293)
([da06439](da064397))

* use autosummary to split documentation pages (#2251)
([f7fd2d2](f7fd2d20))

</details>
TrevorBergeron added a commit that referenced this pull request Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.