Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: use EUC for AI generation functions when connection_id is not present #2272

Merged
tswast merged 7 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
sycai_ai_gen_eucgoogleapis/python-bigquery-dataframes:sycai_ai_gen_eucCopy head branch name to clipboard
Nov 18, 2025
Merged

feat: use EUC for AI generation functions when connection_id is not present #2272
tswast merged 7 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
sycai_ai_gen_eucgoogleapis/python-bigquery-dataframes:sycai_ai_gen_eucCopy head branch name to clipboard

Conversation

@sycai

@sycai sycai commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Fixes #460856043 🦕

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 14, 2025
@sycai sycai changed the title Sycai ai gen euc feat: use EUC for AI generation functions when connection_id is not present Nov 14, 2025
@sycai sycai marked this pull request as ready for review November 14, 2025 23:28
@sycai sycai requested review from a team and chelsea-lin November 14, 2025 23:28

@tswast tswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctest failures appear to be related

FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_bool
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_double
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_int

@sycai

sycai commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

doctest failures appear to be related

FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_bool
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_double
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_int

Yeah those look like permission failures. I guess our doc runners don't have EUC permissions for AI functions.

@tswast

tswast commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

cl/828515544 may be a useful example. that's where I granted the samples tests users permissions. that shouldn't affect doctest, though. doctest should use the compute engine service account from bigframes-dev.

@sycai

sycai commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

cl/828515544 may be a useful example. that's where I granted the samples tests users permissions. that shouldn't affect doctest, though. doctest should use the compute engine service account from bigframes-dev.

Would doctest be considered a background job (I'm not very familiar with these setups)? If that's true, then we will need to explicitly provide a connection_id too 🧐.

@sycai sycai added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2025
@sycai

sycai commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

Do not merge this PR until related failures in doc tests and notebook tests are gone

@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025
@sycai sycai removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 18, 2025
@sycai sycai requested a review from tswast November 18, 2025 01:21
@tswast

tswast commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

e2e failures appear unrelated

FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_max_instances[set-None]
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_max_instances[no-set]
FAILED tests/system/large/streaming/test_bigtable.py::test_streaming_df_to_bigtable
FAILED tests/system/large/streaming/test_pubsub.py::test_streaming_df_to_pubsub

@tswast tswast merged commit 7c062a6 into main Nov 18, 2025
24 of 25 checks passed
@tswast tswast deleted the sycai_ai_gen_euc branch November 18, 2025 19:01
@GarrettWu GarrettWu mentioned this pull request Dec 3, 2025
GarrettWu added a commit that referenced this pull request Dec 3, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>bigframes: 2.30.0</summary>

##
[2.30.0](v2.29.0...v2.30.0)
(2025-12-03)

### Features

* Support mixed scalar-analytic expressions (#2239)
([20ab469](20ab469d))

* Allow drop_duplicates over unordered dataframe (#2303)
([52665fa](52665fa5))

* Preserve source names better for more readable sql (#2243)
([64995d6](64995d65))

* use end user credentials for `bigframes.bigquery.ai` functions when
`connection_id` is not present (#2272)
([7c062a6](7c062a68))

* pivot_table supports fill_value arg (#2257)
([8f490e6](8f490e68))

* Support builtins funcs for df.agg (#2256)
([956a5b0](956a5b00))

* add bigquery.json_keys (#2286)
([b487cf1](b487cf1f))

* Add agg/aggregate methods to windows (#2288)
([c4cb39d](c4cb39dc))

* Add bigframes.pandas.crosstab (#2231)
([c62e553](c62e5535))

* Implement single-column sorting for interactive table widget (#2255)
([d1ecc61](d1ecc61b))

### Bug Fixes

* Pass credentials properly for read api instantiation (#2280)
([3e3fe25](3e3fe259))

* Update max_instances default to reflect actual value (#2302)
([4489687](4489687e))

* Improve Anywidget pagination and display for unknown row counts
(#2258)
([508deae](508deae5))

* Fix issue with stream upload batch size upload limit (#2290)
([6cdf64b](6cdf64b0))

* calling info() on empty dataframes no longer leads to errors (#2267)
([95a83f7](95a83f77))

* do not warn with DefaultIndexWarning in partial ordering mode (#2230)
([cc2dbae](cc2dbae6))

### Documentation

* update docs and tests for Gemini 2.5 models (#2279)
([08c0c0c](08c0c0c8))

* Add Google Analytics configuration to conf.py (#2301)
([0b266da](0b266da1))

* fix LogisticRegression docs rendering (#2295)
([32e5313](32e53134))

* update API reference to new `dataframes.bigquery.dev` location (#2293)
([da06439](da064397))

* use autosummary to split documentation pages (#2251)
([f7fd2d2](f7fd2d20))

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.