Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Fix: add roundingmode as str test#2098

Merged
chalmerlowe merged 2 commits into
pangea-v1alphagoogleapis/python-bigquery:pangea-v1alphafrom
fix-add-roundingmode-as-str-testgoogleapis/python-bigquery:fix-add-roundingmode-as-str-testCopy head branch name to clipboard
Jan 2, 2025
Merged

Fix: add roundingmode as str test#2098
chalmerlowe merged 2 commits into
pangea-v1alphagoogleapis/python-bigquery:pangea-v1alphafrom
fix-add-roundingmode-as-str-testgoogleapis/python-bigquery:fix-add-roundingmode-as-str-testCopy head branch name to clipboard

Conversation

@chalmerlowe

Copy link
Copy Markdown
Collaborator

Adds a roundingmode test of a conditional branch that was inadvertantly stripped out by a recent change in PR: #2097

@chalmerlowe chalmerlowe requested review from a team and Neenu1995 January 2, 2025 16:54
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 2, 2025
@chalmerlowe chalmerlowe changed the base branch from main to pangea-v1alpha January 2, 2025 16:55
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. and removed size: xl Pull request size is extra large. labels Jan 2, 2025
@chalmerlowe chalmerlowe removed the request for review from Neenu1995 January 2, 2025 17:14
@chalmerlowe chalmerlowe changed the title Fix add roundingmode as str test Fix: add roundingmode as str test Jan 2, 2025
@chalmerlowe chalmerlowe assigned tswast and unassigned Linchin Jan 2, 2025
@chalmerlowe chalmerlowe merged commit 100708d into pangea-v1alpha Jan 2, 2025
@chalmerlowe chalmerlowe deleted the fix-add-roundingmode-as-str-test branch January 2, 2025 17:23
chalmerlowe added a commit that referenced this pull request Jan 2, 2025
* fix: adds test of roundingmode as a str

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.