Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: preserve unknown fields from the REST API representation in SchemaField#2097

Merged
tswast merged 5 commits into
maingoogleapis/python-bigquery:mainfrom
tswast-schemafield-refactorgoogleapis/python-bigquery:tswast-schemafield-refactorCopy head branch name to clipboard
Dec 27, 2024
Merged

feat: preserve unknown fields from the REST API representation in SchemaField#2097
tswast merged 5 commits into
maingoogleapis/python-bigquery:mainfrom
tswast-schemafield-refactorgoogleapis/python-bigquery:tswast-schemafield-refactorCopy head branch name to clipboard

Conversation

@tswast

@tswast tswast commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards simplifying #2081
Fixes #6 even more than it already was by avoiding even more copy operations.
🦕

@tswast tswast requested review from a team and agrawal-siddharth December 27, 2024 19:58
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 27, 2024
@tswast tswast requested review from Linchin and chalmerlowe and removed request for agrawal-siddharth December 27, 2024 20:09
@tswast tswast assigned chalmerlowe and unassigned Neenu1995 Dec 27, 2024

@Linchin Linchin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tswast tswast merged commit aaf1eb8 into main Dec 27, 2024
@tswast tswast deleted the tswast-schemafield-refactor branch December 27, 2024 22:55
@tswast tswast changed the title feat: preserve unknown fields from the REST API representaton in SchemaField feat: preserve unknown fields from the REST API representation in SchemaField Dec 27, 2024
chalmerlowe pushed a commit that referenced this pull request Jan 2, 2025
…hemaField` (#2097)

* feat: preserve unknown fields from the REST API representaton in `SchemaField`

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* remove unnecessary variable

* remove unused private method

* fix pytype

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lkhagvadorj-amp pushed a commit to lkhagvadorj-amp/python-bigquery that referenced this pull request Feb 21, 2025
…hemaField` (googleapis#2097)

* feat: preserve unknown fields from the REST API representaton in `SchemaField`

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* remove unnecessary variable

* remove unused private method

* fix pytype

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: complex repeated schema fields are slow

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.