Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jun 2, 2026. It is now read-only.

test: update FakeStorageRpc to extend StorageRpcTestBase - #135

#135
Merged
frankyn merged 5 commits into
googleapis:mastergoogleapis/java-storage-nio:masterfrom
dmitry-fa:fake-storage-rpcdmitry-fa/java-storage-nio:fake-storage-rpcCopy head branch name to clipboard
Jun 17, 2020
Merged

test: update FakeStorageRpc to extend StorageRpcTestBase#135
frankyn merged 5 commits into
googleapis:mastergoogleapis/java-storage-nio:masterfrom
dmitry-fa:fake-storage-rpcdmitry-fa/java-storage-nio:fake-storage-rpcCopy head branch name to clipboard

Conversation

@dmitry-fa

@dmitry-fa dmitry-fa commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

Fixes #124

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2020
@codecov

codecov Bot commented Jun 15, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #135 into master will increase coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
+ Coverage     70.11%   71.43%   +1.32%     
  Complexity      483      483              
============================================
  Files            29       29              
  Lines          1673     1642      -31     
  Branches        265      265              
============================================
  Hits           1173     1173              
+ Misses          376      345      -31     
  Partials        124      124
Impacted Files Coverage Δ Complexity Δ
...ud/storage/contrib/nio/testing/FakeStorageRpc.java 67.94% <ø> (+8.77%) 43.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68508ce...0565ce1. Read the comment docs.

@dmitry-fa dmitry-fa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2020
@dmitry-fa

dmitry-fa commented Jun 15, 2020

Copy link
Copy Markdown
Contributor Author

@frankyn, @chingor13, @JesseLovelace
I added a new class in java-storage 1.109.0 and try to use this class in java-storage-nio.
Everything is fine, but linkage-monitor check fails: the new class is not found. Looks like the linkage-monitor refers to an outdated version of java-storage.
Could you give me any advice on how to handle this?

@frankyn

frankyn commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

Hi @dmitry-fa, thanks for putting this together. I merged the updated version of Java-storage. Please merge master into your branch.

@frankyn

frankyn commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

@kolea2 could you help release a new version of libraries-bom with updated versions of google-cloud-storage and google-cloud-nio? It will help unblock this PR.

@dmitry-fa dmitry-fa mentioned this pull request Jun 16, 2020
Closed
@dmitry-fa dmitry-fa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2020
@frankyn

frankyn commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

Merge master @dmitry-fa

@frankyn
frankyn merged commit 3233a4c into googleapis:master Jun 17, 2020
@frankyn frankyn mentioned this pull request Jun 17, 2020
Closed
@frankyn frankyn added the release-please:force-run To run release-please label Jun 17, 2020
@release-please release-please Bot removed the release-please:force-run To run release-please label Jun 17, 2020
@chingor13 chingor13 added the fix label Jun 17, 2020
frankyn pushed a commit that referenced this pull request Jun 18, 2020
Frank Natividad
fix: release fix #135
9e7d30e
@frankyn frankyn mentioned this pull request Jun 18, 2020
Merged
frankyn added a commit that referenced this pull request Jun 18, 2020
@frankyn
fix: update FakeStorageRpc to extend StorageRpcTestBase #135
7614295
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jun 18, 2020
@release-please
chore: release 0.120.2 (#149)
a4e3a51 
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.120.2](https://www.github.com/googleapis/java-storage-nio/compare/v0.120.1...v0.120.2) (2020-06-18)


### Bug Fixes

* update FakeStorageRpc to extend StorageRpcTestBase [#135](https://www.github.com/googleapis/java-storage-nio/issues/135) ([7614295](https://www.github.com/googleapis/java-storage-nio/commit/761429571eea15b11b2d44b4f5a2c65b4f649484))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@rbraeunlich rbraeunlich mentioned this pull request Jul 20, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13
@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace
1 more reviewer
@frankyn frankyn frankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: update FakeStorageRpc to extend StorageRpcTestBase

5 participants

@dmitry-fa @frankyn @chingor13 @googlebot @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.