This repository was archived by the owner on Jun 2, 2026. It is now read-only.
This repository was archived by the owner on Jun 2, 2026. It is now read-only.
Implement writeWithResponse in FakeStorageRpc #175
Metadata
Metadata
Assignees
Labels
Issues related to the googleapis/java-storage-nio API.Issues related to the googleapis/java-storage-nio API.Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Is your feature request related to a problem? Please describe.
With Pull Request #135 the
FakeStorageRpcclass extendsStorageRpcTestBaseand now google-cloud-storage is a needed dependency when using the class in tests. In google-cloud-storage the implementation of BlobWriteChannel has been changed a month ago (https://github.com/googleapis/java-storage/pull/269/files#diff-8561e6a9172119adf8e882a3f5298d6bR69) so thatflushBuffernow callswriteWithResponseinstead ofwrite.writeWithResponseis neither implemented inFakeStorageRpcnor inStorageRpcTestBase, which causes my tests to crash now, which didn't happen before.Describe the solution you'd like
Please implement the method. Since the response is a StorageObject it shouldn't cause any problems.
Describe alternatives you've considered
My workaround is now to set my dependency to google-cloud-storage fixed to 1.110.0. But this pins me on this version.