Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat: migrate to OTEL and enable metrics by default#2166

Merged
mutianf merged 35 commits into
maingoogleapis/java-bigtable:mainfrom
otelgoogleapis/java-bigtable:otelCopy head branch name to clipboard
Apr 12, 2024
Merged

feat: migrate to OTEL and enable metrics by default#2166
mutianf merged 35 commits into
maingoogleapis/java-bigtable:mainfrom
otelgoogleapis/java-bigtable:otelCopy head branch name to clipboard

Conversation

@mutianf

@mutianf mutianf commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

mutianf and others added 11 commits January 23, 2024 10:07
* feat: migrate exporter to OTEL

* address comments

* filter out only bigtable metrics

* fix test

* use the bom

* update

* update

* update completeResultCode

* add a comment

* address comments

* address comments

* update pom

* small fix

* also check timestamp

* address comment

* updates

* update

* do not block on shutdown
* feat: migrate exporter to OTEL

* address comments

* filter out only bigtable metrics

* fix test

* use the bom

* update

* update

* feat: migrate builtin metrics to OTEl

* update completeResultCode

* add a comment

* udpate

* fix tests

* remove unrelated changes

* fix tests

* add documentation

* fix test

* merge exporter changes

* address comments

* rebase on otel

* revert changes in stats

* fix import

* update

* merge back the endpoint change

* refactor constants and settings

* refactor and fix tests

* remove unused dependency

* add some javadoc

* address part of the comments

* update test

* test with nano

* measure everything in nanos and publish with double histogram

* address comments

* fix test

* add toString
* feat: migrate per connection error count metric to otel

* update test

* address comments

* remove unnecessary check

* clean up statsRecorder

* remove dependency

* address comments
@mutianf mutianf requested review from a team March 13, 2024 01:31
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 13, 2024
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2024
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2024
@mutianf

mutianf commented Apr 12, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.