Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat: migrate per connection error count metric to otel#2133

Merged
mutianf merged 7 commits into
googleapis:otelgoogleapis/java-bigtable:otelfrom
mutianf:connection-errormutianf/java-bigtable:connection-errorCopy head branch name to clipboard
Mar 4, 2024
Merged

feat: migrate per connection error count metric to otel#2133
mutianf merged 7 commits into
googleapis:otelgoogleapis/java-bigtable:otelfrom
mutianf:connection-errormutianf/java-bigtable:connection-errorCopy head branch name to clipboard

Conversation

@mutianf

@mutianf mutianf commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team February 26, 2024 18:17
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Feb 26, 2024
@mutianf mutianf merged commit cd3467c into googleapis:otel Mar 4, 2024
@mutianf mutianf deleted the connection-error branch March 4, 2024 19:54
mutianf added a commit that referenced this pull request Apr 12, 2024
* feat: migrate to OTEL exporter (#1788)

* feat: migrate exporter to OTEL

* address comments

* filter out only bigtable metrics

* fix test

* use the bom

* update

* update

* update completeResultCode

* add a comment

* address comments

* address comments

* update pom

* small fix

* also check timestamp

* address comment

* updates

* update

* do not block on shutdown

* chore: refactor factory class (#2081)

* chore: refactor TracerFactory creation (#2102)

* feat: migrate built in metrics to OTEL (#1796)

* feat: migrate exporter to OTEL

* address comments

* filter out only bigtable metrics

* fix test

* use the bom

* update

* update

* feat: migrate builtin metrics to OTEl

* update completeResultCode

* add a comment

* udpate

* fix tests

* remove unrelated changes

* fix tests

* add documentation

* fix test

* merge exporter changes

* address comments

* rebase on otel

* revert changes in stats

* fix import

* update

* merge back the endpoint change

* refactor constants and settings

* refactor and fix tests

* remove unused dependency

* add some javadoc

* address part of the comments

* update test

* test with nano

* measure everything in nanos and publish with double histogram

* address comments

* fix test

* add toString

* merge from main

* feat: migrate per connection error count metric to otel (#2133)

* feat: migrate per connection error count metric to otel

* update test

* address comments

* remove unnecessary check

* clean up statsRecorder

* remove dependency

* address comments

* feat: migrate per connection error exporter to otel (#2152)

* chore: clean up stats package (#2163)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix clirr and  integration test

* fix clirr and  integration test

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* log more information on test failures

* address comments

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* include version

* fix flaky test

* remove otel dependencies since they're added to shared dependencies

* backport new tests since 2.37

* set feature flag when metrics is enabled

* record metrics whenever it's registered

* record metrics whenever it's registered

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* remove stale reference

* clean up

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.