Storage: Add client_options to constructors for manual clients.#9054
Merged
busunkim96 merged 3 commits intoAug 28, 2019
googleapis:mastergoogleapis/google-cloud-python:masterfrom
MaxxleLLC:add-client_options-to-storageMaxxleLLC/google-cloud-python:add-client_options-to-storageCopy head branch name to clipboard
Merged
Storage: Add client_options to constructors for manual clients.#9054busunkim96 merged 3 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom MaxxleLLC:add-client_options-to-storageMaxxleLLC/google-cloud-python:add-client_options-to-storageCopy head branch name to clipboard
client_options to constructors for manual clients.#9054busunkim96 merged 3 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
MaxxleLLC:add-client_options-to-storageMaxxleLLC/google-cloud-python:add-client_options-to-storageCopy head branch name to clipboard
Conversation
Applying requested chgs.
* added new test to check 'client_options' as a dict * deleted extra asserts * chged couple of objects to an alternative value
19 tasks
tseaver
approved these changes
Aug 27, 2019
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
emar-kar
added a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
31 tasks
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #8475