Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update pin for 'googleapis-common-protos'. #8686

Copy link
Copy link

Description

@tseaver
Issue body actions

From #8674.

Recent autogen changes have begun using features present only in googleapis-common-protos 1.6.0+, specifially the google.api.client package. E.g.:

$ git grep -l "google\/api\/client\.proto" | grep "\.proto$"
automl/google/cloud/automl_v1beta1/proto/prediction_service.proto
automl/google/cloud/automl_v1beta1/proto/service.proto
bigquery/google/cloud/bigquery_v2/proto/model.proto
bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/storage.proto
datacatalog/google/cloud/datacatalog_v1beta1/proto/datacatalog.proto
datalabeling/google/cloud/datalabeling_v1beta1/proto/data_labeling_service.proto
dlp/google/cloud/dlp_v2/proto/dlp.proto
irm/google/cloud/irm_v1alpha2/proto/incidents_service.proto
kms/google/cloud/kms_v1/proto/service.proto
language/google/cloud/language_v1/proto/language_service.proto
redis/google/cloud/redis_v1/proto/cloud_redis.proto
redis/google/cloud/redis_v1beta1/proto/cloud_redis.proto
talent/google/cloud/talent_v4beta1/proto/application_service.proto
talent/google/cloud/talent_v4beta1/proto/company_service.proto
talent/google/cloud/talent_v4beta1/proto/completion_service.proto
talent/google/cloud/talent_v4beta1/proto/event_service.proto
talent/google/cloud/talent_v4beta1/proto/job_service.proto
talent/google/cloud/talent_v4beta1/proto/profile_service.proto
talent/google/cloud/talent_v4beta1/proto/tenant_service.proto
translate/google/cloud/translate_v3beta1/proto/translation_service.proto
videointelligence/google/cloud/videointelligence_v1/proto/video_intelligence.proto

This "leakage" can break clients who are upgrading an existing virtualenv, because ce currently pin googleapis-common-protos >= 1.5.3, != 1.5.4, < 2.0dev in api_core/setup.py, and googleapis-common-protos >= 1.5.9, < 2.0.0dev in bigquery_storage/setup.py.

Steps to remediate:

Bump pins of google-cloud-core >= 1.0.3, < 2.0.0dev:

Release the world (as of 2019-10-10):

After merge of #9445:

After release of google-cloud-logging:

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

api: automlIssues related to the AutoML API.Issues related to the AutoML API.api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.api: bigquerystorageIssues related to the BigQuery Storage API.Issues related to the BigQuery Storage API.api: bigtableIssues related to the Bigtable API.Issues related to the Bigtable API.api: clouderrorreportingIssues related to the Error Reporting API.Issues related to the Error Reporting API.api: cloudkmsIssues related to the Cloud Key Management Service API.Issues related to the Cloud Key Management Service API.api: cloudresourcemanagerIssues related to the Resource Manager API.Issues related to the Resource Manager API.api: coreapi: datacatalogIssues related to the Data Catalog API.Issues related to the Data Catalog API.api: datalabelingIssues related to the AI Platform Data Labeling Service API.Issues related to the AI Platform Data Labeling Service API.api: dlpIssues related to the Sensitive Data Protection API.Issues related to the Sensitive Data Protection API.api: dnsIssues related to the Cloud DNS API.Issues related to the Cloud DNS API.api: firestoreIssues related to the Firestore API.Issues related to the Firestore API.api: irmapi: languageIssues related to the Cloud Natural Language API API.Issues related to the Cloud Natural Language API API.api: loggingIssues related to the Cloud Logging API.Issues related to the Cloud Logging API.api: phishingprotectionIssues related to the Phishing Protection API.Issues related to the Phishing Protection API.api: redisIssues related to the Memorystore for Redis API.Issues related to the Memorystore for Redis API.api: runtimeconfigIssues related to the Cloud Runtime Config API API.Issues related to the Cloud Runtime Config API API.api: spannerIssues related to the Spanner API.Issues related to the Spanner API.api: talentapi: translationIssues related to the Cloud Translation API API.Issues related to the Cloud Translation API API.api: videointelligenceIssues related to the Video Intelligence API API.Issues related to the Video Intelligence API API.packagingtype: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.