Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 7, 2015

  • Make require_dataset_id and '_require_connection' take the passed object, and test explicitly against None.
  • Tweak docstrings to reflect API changes.
  • Clarify implicit environ tests.
  • Clarify dependency on implicit environ in key tests.

- Rework '_require_dataset' -> '_require_dataset_id'.

  Also, make both it and '_require_connection' take the passed object,
  and test explicitly against None.

- Docstring tweaks to reflect API reshapings.

- Clarify implicit environ tests.

- Clarify dependency on implicit environ in key tests.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

./gcloud/datastore/key.py:78:5: E303 too many blank lines (2)

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

Your favorite:

./gcloud/datastore/test_key.py:100:25: E128 continuation line under-indented for visual indent
./gcloud/datastore/test_key.py:132:13: E128 continuation line under-indented for visual indent
./gcloud/datastore/test_key.py:136:29: E127 continuation line over-indented for visual indent
./gcloud/datastore/test_key.py:138:29: E127 continuation line over-indented for visual indent
./gcloud/datastore/test_key.py:140:29: E127 continuation line over-indented for visual indent
./gcloud/datastore/test_key.py:141:29: E127 continuation line over-indented for visual indent

Suggest just lining up with word / line beginning.

@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

LGTM pending lint issues.

Also probably worth fixing the kw dataset= in test_ctor_w_implicit_dataset_id_empty_path,

tseaver added a commit that referenced this pull request Jan 7, 2015
@tseaver tseaver merged commit 0eca209 into googleapis:master Jan 7, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 90829f5 on tseaver:cherrypick-499 into 7019708 on GoogleCloudPlatform:master.

@tseaver tseaver deleted the cherrypick-499 branch January 7, 2015 22:18
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Aug 15, 2023
…p/templates/python_library/.kokoro (#501)

Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Source-Link: googleapis/synthtool@eb78c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163
parthea added a commit that referenced this pull request Sep 22, 2023
…501)

* Repo clean-up

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Rename samples/README.md to samples/snippets/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
There was some refactoring, and the bigtable_v2/proto directory no longer exists.
Updated the links to the correct ones, and used permalink.
parthea pushed a commit that referenced this pull request Nov 24, 2025
* updated CHANGELOG.md [ci skip]

* updated setup.py

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* Sets cache support to false, removes upper req limit

* fix: adds timestamp to ensure tests pass successfully

* fix: updates tests to account for UTC

* restores path in nox session
parthea added a commit that referenced this pull request Nov 24, 2025
…lates/python_library/.kokoro (#501)

Source-Link: googleapis/synthtool@9367caa
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2f155882785883336b4468d5218db737bb1d10c9cea7cb62219ad16fe248c03c

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sanche <sanche@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 26, 2025
* This patch for </issues/501> includes the following fixes:

- The access token is always set to `None`, so the fix involves using (the access) `token` from the saved JSON credentials file.
- For refresh needs, `expiry` also needs to be saved via `to_json()`.
    - DUMP: As `expiry` is a `datetime.datetime` object, serialize to `datetime.isoformat()` in the same [`oauth2client` format](https://github.com/googleapis/oauth2client/blob/master/oauth2client/client.py#L55) for consistency.
    - LOAD: Add code to restore `expiry` back to `datetime.datetime` object when imported.
    - LOAD: If `expiry` was unsaved, automatically set it as expired so refresh takes place.
- Minor `scopes` updates
    - DUMP: Add property for `scopes` so `to_json()` can grab it
    - LOAD: `scopes` may be saved as a string instead of a JSON array (Python list), so ensure it is Sequence[str] when imported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.