Removing datastore.Dataset class and its uses. #500

dhermes · Jan 7, 2015

Addresses part 8 of #477.

@tseaver What do you want to do about #499? We can finish that review and I can rebase this, but it will likely be quite difficult.

I have put off doc changes (unless necessary, e.g. the RST docs which would not build without the class) and will tackle that next.

I have also not yet been able to resolve the cyclic import in Key.get() but I am leaning towards simply removing it and renaming datastore.__init__.get_entities to datastore.__init__.get (and allowing a Key or a list of Keys).

Addresses part 8 of googleapis#477.

dhermes · Jan 7, 2015

Also, I need to fix the following "extra" modules:

gcloud/datastore/demo/...
regression/populate_datastore.py
regression/clear_datastore.py

I have put it off for now since each can be done in an individual (easier to review) PR.

coveralls · Jan 7, 2015

Coverage remained the same when pulling e998859 on dhermes:fix-477-part8 into f176098 on GoogleCloudPlatform:master.

gcloud/datastore/key.py

-            if _implicit_environ.DATASET is not None:
-                # This assumes DATASET.id() is not None.
-                self._dataset_id = _implicit_environ.DATASET.id()
+            if _implicit_environ.DATASET_ID is not None:


Removing datastore.Dataset class and its uses.

dhermes · Jan 7, 2015

@tseaver I am going to try to do a large docs fix-up. After your cherry-pick of #499 is in, how do you want to divvy up:

gcloud/datastore/demo/...
regression/populate_datastore.py
regression/clear_datastore.py

tseaver · Jan 7, 2015

how about I tackle the 'demo' stuff, and you the 'regression'?

dhermes · Jan 7, 2015

SGTM. I'm going to tackle docs first after we're done with #501 and then get to that.

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@25083af Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0

) Source-Link: googleapis/synthtool@d6103f4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39f0f3f2be02ef036e297e376fe3b6256775576da8a6ccb1d5eeb80f4c8bf8fb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…500) Source-Link: googleapis/synthtool@395d53a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@703554a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b

The console-based copy-paste-a-token flow has been deprecated. See: https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html?m=1#disallowed-oob Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕

🤖 I have created a release *beep* *boop* --- ### [0.17.4](googleapis/python-bigquery-pandas@v0.17.3...v0.17.4) (2022-03-14) ### Bug Fixes * avoid deprecated "out-of-band" authentication flow ([#500](googleapis/python-bigquery-pandas#500)) ([4758e3a](googleapis/python-bigquery-pandas@4758e3a)) * correctly transform query job timeout configuration and exceptions ([#492](googleapis/python-bigquery-pandas#492)) ([d8c3900](googleapis/python-bigquery-pandas@d8c3900)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. fix: resolve DuplicateCredentialArgs error when using credentials_file committer: parthea PiperOrigin-RevId: 425964861 Source-Link: googleapis/googleapis@84b1a5a Source-Link: googleapis/googleapis-gen@4fb761b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9

* chore: update templated files * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…mplates/python_library/.kokoro (#500) Source-Link: googleapis/synthtool@30bd01b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(python): bump idna from 3.4 to 3.7 in .kokoro Source-Link: googleapis/synthtool@d50980e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5a4c19d17e597b92d786e569be101e636c9c2817731f80a5adec56b2aa8fe070 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>

Also, remove weird mocking for BIDI classes.

~~Based on branch for PR #500 -- I will rebase after that PR merges.~~ Closes #367. Supersedes PR #497.

Co-authored-by: Tianzi Cai <tianzi@google.com>

Removing datastore.Dataset class and its uses.

e998859

Addresses part 8 of googleapis#477.

dhermes mentioned this pull request Jan 7, 2015

477: Prepare to remove dataset #499

Closed

tseaver reviewed Jan 7, 2015
View reviewed changes

tseaver added a commit that referenced this pull request Jan 7, 2015

Merge pull request #500 from dhermes/fix-477-part8

7019708

Removing datastore.Dataset class and its uses.

tseaver merged commit 7019708 into googleapis:master Jan 7, 2015

dhermes deleted the fix-477-part8 branch January 7, 2015 20:09

dhermes mentioned this pull request Jan 7, 2015

Update regression scripts to work with new API. #502

Merged

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

parthea added a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.13.7 (#500)

30133bd

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea added a commit that referenced this pull request Oct 21, 2023

fix(deps): allow protobuf 3.19.5 (#500)

a1b1f24

* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0

parthea pushed a commit that referenced this pull request Nov 24, 2025

refactor: use 'WhichOneof' for dispatch in 'Watch.on_snapshot' (#500)

947aec2

Also, remove weird mocking for BIDI classes.

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: stop / start stream after filter mismatch (#502)

829616d

~~Based on branch for PR #500 -- I will rebase after that PR merges.~~ Closes #367. Supersedes PR #497.

parthea pushed a commit that referenced this pull request Nov 24, 2025

build: pick up changes from synthtool (#500)

509f4d9

parthea pushed a commit that referenced this pull request Nov 26, 2025

feat: check 'iss' in verify_oauth2_token (#500)

e9b5f7c

Co-authored-by: Tianzi Cai <tianzi@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing datastore.Dataset class and its uses. #500

Removing datastore.Dataset class and its uses. #500

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

coveralls commented Jan 7, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

tseaver commented Jan 7, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Search code, repositories, users, issues, pull requests...

Removing datastore.Dataset class and its uses. #500

Removing datastore.Dataset class and its uses. #500

Uh oh!

Conversation

dhermes commented Jan 7, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

coveralls commented Jan 7, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

tseaver commented Jan 7, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants