Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 1, 2015

This was very out of place as a method on Connection in storage.

This was **very** out of place as a method on Connection in storage.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2015
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Feb 1, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0d70e9c on dhermes:move-signed-url-to-credentials into d858ff0 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Feb 3, 2015

I can hardly object: this is basically the same as my #356, which was aimed at #57.

@dhermes
Copy link
Contributor Author

dhermes commented Feb 3, 2015

Ha I vaguely remembered being a party pooper on that one.

I should have trusted your "this feels out of place" instincts.

This also brings up the question: How do GAE / GCE service accounts hope to sign a URL?

@dhermes
Copy link
Contributor Author

dhermes commented Feb 3, 2015

Also @tseaver is your endorsement above a LGTM or are you still reviewing?

@tseaver
Copy link
Contributor

tseaver commented Feb 3, 2015

LGTM

dhermes added a commit that referenced this pull request Feb 3, 2015
Move generate_signed_url to standalone function in credentials.
@dhermes dhermes merged commit e80958a into googleapis:master Feb 3, 2015
@dhermes dhermes deleted the move-signed-url-to-credentials branch February 3, 2015 19:23
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
* feat: add support for directly attached and effective tags
docs: clarify comments for tags and effective tags

Clients can search resources filtered by effective tags and start to use the new `tags` field instead of old `tag_key`, `tag_value`, `tag_value_id` fields to access directly attached tags.

PiperOrigin-RevId: 567554529

Source-Link: googleapis/googleapis@1a3ea87

Source-Link: googleapis/googleapis-gen@df4f7ba
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGY0ZjdiYTQxYTgwN2ExOTNiNDhhZmRiYThkNGFlZjM1NjM2ODc1YSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Oct 31, 2023
parthea pushed a commit that referenced this pull request Aug 21, 2025
parthea pushed a commit that referenced this pull request Sep 16, 2025
parthea pushed a commit that referenced this pull request Nov 22, 2025
* feat: refreshes Bigtable Admin API(s) protos

PiperOrigin-RevId: 448988001

Source-Link: googleapis/googleapis@b6fa58e

Source-Link: googleapis/googleapis-gen@fc8b8db
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmM4YjhkYmM3ZGExYTc4NDVkNTcxMzRmNDExMzAyZDEwNmVhMmVmMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Implement the two mtls env variables mentioned in https://google.aip.dev/auth/4114

New behavior summary:
(1) GOOGLE_API_USE_CLIENT_CERTIFICATE env variable:
Values:
"true": use client cert if exists
"false" (default): never use client cert, even if it exists or it is explicitly provided by user
(2) GOOGLE_API_USE_MTLS_ENDPOINT env variable:
Values:
"never": use regular endpoint
"always": use mtls endpoint
"auto" (default): auto switch to mtls endpoint, if client cert exists and we are allowed to use it (controlled by GOOGLE_API_USE_CLIENT_CERTIFICATE)
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* fix: make nested retry blocks work for RPC calls
fixes #567

* fix: use special retry exception to return flow to outer retry block

Co-authored-by: Andrew Gorcester <gorcester@google.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
* This patch for </issues/501> includes the following fixes:

- The access token is always set to `None`, so the fix involves using (the access) `token` from the saved JSON credentials file.
- For refresh needs, `expiry` also needs to be saved via `to_json()`.
    - DUMP: As `expiry` is a `datetime.datetime` object, serialize to `datetime.isoformat()` in the same [`oauth2client` format](https://github.com/googleapis/oauth2client/blob/master/oauth2client/client.py#L55) for consistency.
    - LOAD: Add code to restore `expiry` back to `datetime.datetime` object when imported.
    - LOAD: If `expiry` was unsaved, automatically set it as expired so refresh takes place.
- Minor `scopes` updates
    - DUMP: Add property for `scopes` so `to_json()` can grab it
    - LOAD: `scopes` may be saved as a string instead of a JSON array (Python list), so ensure it is Sequence[str] when imported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.