Making datastore Connection.lookup() return low-level protobuf.#3094
Merged
dhermes merged 1 commit intoMar 3, 2017
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:fix-2746-lookupdhermes/google-cloud-python:fix-2746-lookupCopy head branch name to clipboard
Merged
Making datastore Connection.lookup() return low-level protobuf.#3094dhermes merged 1 commit intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:fix-2746-lookupdhermes/google-cloud-python:fix-2746-lookupCopy head branch name to clipboard
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:fix-2746-lookupdhermes/google-cloud-python:fix-2746-lookupCopy head branch name to clipboard
Conversation
daspecster
reviewed
Mar 3, 2017
|
|
||
| if missing is not None: | ||
| missing.extend(missing_found) | ||
| missing.extend(result.entity for result in lookup_response.missing) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Making datastore Connection.lookup() return low-level protobuf.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Making datastore Connection.lookup() return low-level protobuf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2746 (as were #3064, #3066, #3091, #3092 and #3093). This approach is to slowly transition from our current approach to use the GAPIC generated surface. This is the sixth and final API method to be converted in this fashion.