Making datastore Connection.commit() return low-level protobuf.#3064
Making datastore Connection.commit() return low-level protobuf.#3064dhermes merged 1 commit intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:fix-2746-commitdhermes/google-cloud-python:fix-2746-commitCopy head branch name to clipboard
Conversation
Towards googleapis#2746 (as is googleapis#3064). This approach is to slowly transition from our current approach to use the GAPIC generated surface. These unit tests weren't so bad to update. I did "editorialize" as I went, downgrading constants to just variables, renamining for PEP8, etc.
|
@dhermes so this is preparatory to adding |
|
@dhermes Is your goal to get this in with the umbrella releaase, or after? |
| :class:`.entity_pb2.Key` for each incomplete key | ||
| that was completed in the commit. | ||
| """ | ||
| mut_results = commit_response_pb.mutation_results |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| ] | ||
| response = datastore_pb2.CommitResponse( | ||
| mutation_results=[ | ||
| datastore_pb2.MutationResult(key=key) for key in keys |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Approved, but holding off on merge until the umbrella release question is answered. |
|
@lukesneeringer A merge is just fine. @tseaver |
Towards googleapis#2746. This approach is to slowly transition from our current approach to use the GAPIC generated surface. It is unfortunately tangled quite a bit (partly because we may have too much mocked in the tests).
56f12dd to
9488e3c
Compare
|
Passing on Travis, not done yet on CircleCI (since it doesn't yet do a restricted set of tests). Merging before CircleCI is done. |
Towards googleapis#2746 (as is googleapis#3064). This approach is to slowly transition from our current approach to use the GAPIC generated surface. These unit tests weren't so bad to update. I did "editorialize" as I went, downgrading constants to just variables, renamining for PEP8, etc.
Making datastore Connection.commit() return low-level protobuf.
Making datastore Connection.commit() return low-level protobuf.
Towards #2746. This approach is to slowly transition from our current approach to use the GAPIC generated surface.
It is unfortunately tangled quite a bit (partly because we may have too much mocked in the tests).