Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Adding new Travis key.#2292

Merged
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:add-new-travis-keydhermes/google-cloud-python:add-new-travis-keyCopy head branch name to clipboard
Sep 9, 2016
Merged

Adding new Travis key.#2292
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:add-new-travis-keydhermes/google-cloud-python:add-new-travis-keyCopy head branch name to clipboard

Conversation

@dhermes

@dhermes dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

PR #2288 broke the Travis build since the key stored (from 2014) didn't have the project ID as a value.

Also adding better instructing about the encrypted file.

PR googleapis#2288 broke the Travis build since the key stored (from 2014)
didn't have the project ID as a value.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2016
@dhermes

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

I've also deleted the old and no longer used file encryption env. vars:

  • encrypted_a1b222e8c14d_key
  • encrypted_a1b222e8c14d_iv
  • encrypted_d4f2fba7a94f_key
  • encrypted_d4f2fba7a94f_iv

@dhermes

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

Merging now to stop the permanent state of b0rken-ness. @tseaver and @daspecster please LMK if the "emergency" merge was problematic.

@dhermes dhermes merged commit 49b3f1b into googleapis:master Sep 9, 2016
@dhermes dhermes deleted the add-new-travis-key branch September 9, 2016 23:06
@dhermes

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

Was ready to say "Yay we're green!" but then:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/158880190

It's just #2080.

@tseaver

tseaver commented Sep 10, 2016

Copy link
Copy Markdown
Contributor

We could merge #2248 to make that one go away. ;)

parthea pushed a commit that referenced this pull request Apr 1, 2026
…2292)

This change aims to fix the tests failing in #2248 because of a 1-based
indexing error.

Fixes internal issue 417774347 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.