Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Stop using a designated tests project ID.#2288

Merged
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:fix-2263dhermes/google-cloud-python:fix-2263Copy head branch name to clipboard
Sep 9, 2016
Merged

Stop using a designated tests project ID.#2288
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:fix-2263dhermes/google-cloud-python:fix-2263Copy head branch name to clipboard

Conversation

@dhermes

@dhermes dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

This is because the project ID can be determined directly from the file pointed to by GOOGLE_APPLICATION_CREDENTIALS.

Fixes #2263.

@dhermes dhermes added the testing label Sep 9, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2016
@dhermes dhermes changed the title Stop uisng a designated tests project ID. Stop using a designated tests project ID. Sep 9, 2016
@tseaver

tseaver commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

LGTM. Lots of pink lines!

@dhermes

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

Blerg! Not quite enough red lines: lint says we got some unused imports.

This is because the project ID can be determined directly from
the file pointed to by GOOGLE_APPLICATION_CREDENTIALS.

Fixes googleapis#2263.
@dhermes dhermes merged commit d42b020 into googleapis:master Sep 9, 2016
@dhermes dhermes deleted the fix-2263 branch September 9, 2016 20:37
@dhermes

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

OK this broke things big time:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/158845211

Looking into it.

@dhermes

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

OK I think I know what happened, the key stored in key.json.enc was an older style key and doesn't have a project_id key.

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Sep 9, 2016
PR googleapis#2288 broke the Travis build since the key stored (from 2014)
didn't have the project ID as a value.
@dhermes dhermes mentioned this pull request Sep 9, 2016
@dhermes

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

Sent #2292 to fix.

@dhermes

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

b0rken here as well:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/158865134

Though this is even more b0rken since I deleted the IV and key env. vars. from Travis.

@dhermes dhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Apr 1, 2026
parthea pushed a commit that referenced this pull request Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>bigframes: 2.30.0</summary>

##
[2.30.0](googleapis/python-bigquery-dataframes@v2.29.0...v2.30.0)
(2025-12-03)

### Features

* Support mixed scalar-analytic expressions (#2239)
([20ab469d](googleapis/python-bigquery-dataframes@20ab469d))

* Allow drop_duplicates over unordered dataframe (#2303)
([52665fa5](googleapis/python-bigquery-dataframes@52665fa5))

* Preserve source names better for more readable sql (#2243)
([64995d65](googleapis/python-bigquery-dataframes@64995d65))

* use end user credentials for `bigframes.bigquery.ai` functions when
`connection_id` is not present (#2272)
([7c062a68](googleapis/python-bigquery-dataframes@7c062a68))

* pivot_table supports fill_value arg (#2257)
([8f490e68](googleapis/python-bigquery-dataframes@8f490e68))

* Support builtins funcs for df.agg (#2256)
([956a5b00](googleapis/python-bigquery-dataframes@956a5b00))

* add bigquery.json_keys (#2286)
([b487cf1f](googleapis/python-bigquery-dataframes@b487cf1f))

* Add agg/aggregate methods to windows (#2288)
([c4cb39dc](googleapis/python-bigquery-dataframes@c4cb39dc))

* Add bigframes.pandas.crosstab (#2231)
([c62e5535](googleapis/python-bigquery-dataframes@c62e5535))

* Implement single-column sorting for interactive table widget (#2255)
([d1ecc61b](googleapis/python-bigquery-dataframes@d1ecc61b))

### Bug Fixes

* Pass credentials properly for read api instantiation (#2280)
([3e3fe259](googleapis/python-bigquery-dataframes@3e3fe259))

* Update max_instances default to reflect actual value (#2302)
([4489687e](googleapis/python-bigquery-dataframes@4489687e))

* Improve Anywidget pagination and display for unknown row counts
(#2258)
([508deae5](googleapis/python-bigquery-dataframes@508deae5))

* Fix issue with stream upload batch size upload limit (#2290)
([6cdf64b0](googleapis/python-bigquery-dataframes@6cdf64b0))

* calling info() on empty dataframes no longer leads to errors (#2267)
([95a83f77](googleapis/python-bigquery-dataframes@95a83f77))

* do not warn with DefaultIndexWarning in partial ordering mode (#2230)
([cc2dbae6](googleapis/python-bigquery-dataframes@cc2dbae6))

### Documentation

* update docs and tests for Gemini 2.5 models (#2279)
([08c0c0c8](googleapis/python-bigquery-dataframes@08c0c0c8))

* Add Google Analytics configuration to conf.py (#2301)
([0b266da1](googleapis/python-bigquery-dataframes@0b266da1))

* fix LogisticRegression docs rendering (#2295)
([32e53134](googleapis/python-bigquery-dataframes@32e53134))

* update API reference to new `dataframes.bigquery.dev` location (#2293)
([da064397](googleapis/python-bigquery-dataframes@da064397))

* use autosummary to split documentation pages (#2251)
([f7fd2d20](googleapis/python-bigquery-dataframes@f7fd2d20))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.