Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Drop 'Table.rename'.#1908

Merged
tseaver merged 2 commits into
googleapis:bigtable-v2googleapis/google-cloud-python:bigtable-v2from
tseaver:bigtable-v2-drop_table_renameCopy head branch name to clipboard
Jun 26, 2016
Merged

Drop 'Table.rename'.#1908
tseaver merged 2 commits into
googleapis:bigtable-v2googleapis/google-cloud-python:bigtable-v2from
tseaver:bigtable-v2-drop_table_renameCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented Jun 26, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

It was never actually implemented on the back-end in V1, and has been dropped altogether in V2.

@tseaver
Drop 'Table.rename'.
9a2d313 
It was never actually implemented on the back-end in V1, and has been
dropped altogether in V2.
@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label Jun 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2016
@tseaver tseaver mentioned this pull request Jun 26, 2016
Closed
@daspecster

daspecster commented Jun 26, 2016

Copy link
Copy Markdown
Contributor

@tseaver looks like there is more to remove for this in the system-test and protos.

https://github.com/GoogleCloudPlatform/gcloud-python/search?utf8=%E2%9C%93&q=rename

@tseaver

tseaver commented Jun 26, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster Thanks forthe catch! OK to merge now?

@daspecster

daspecster commented Jun 26, 2016

Copy link
Copy Markdown
Contributor

There's some in the proto as well. But if we don't care about that since it's generated then LGTM!

@tseaver

tseaver commented Jun 26, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster

There's some in the proto as well. But if we don't care about that since it's generated then LGTM!

Yup, the _generated/ subdir is based on the Bigtable V1 protos, which contained that method, even though the backend always returned a NOT_IMPLEMENTED error. The V2 proto-generated code is added in #1903, and doesn't have the method.

Eventually (see #1384), we'd like to get rid of both those directories and rely on googleapis-generated PyPI releases for datastore and bigtable proto-generated code.

@tseaver tseaver merged commit 35103f9 into googleapis:bigtable-v2 Jun 26, 2016
@tseaver tseaver deleted the bigtable-v2-drop_table_rename branch June 26, 2016 20:33
This was referenced Jun 28, 2016
Closed
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore(main): release 1.13.1 (#1908)
df2a075 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @daspecster @dhermes @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.