Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Generate code for Bigtable v2 protobufs#1903

Merged
tseaver merged 3 commits into
googleapis:bigtable-v2googleapis/google-cloud-python:bigtable-v2from
tseaver:bigtable-v2-regenerate_protobufsCopy head branch name to clipboard
Jun 26, 2016
Merged

Generate code for Bigtable v2 protobufs#1903
tseaver merged 3 commits into
googleapis:bigtable-v2googleapis/google-cloud-python:bigtable-v2from
tseaver:bigtable-v2-regenerate_protobufsCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented Jun 24, 2016

Copy link
Copy Markdown
Contributor

Put V2-generated files them in a separate _generated_v2 subdir, to ease migration.

Attempt to factor generation process for clarity (toward #1482).

Supersedes #1895.

tseaver added 2 commits June 24, 2016 15:59
Pass the 'PROTOC_CMD' and 'GRPC_PLUGIN' values through from make's
environment to the scripts used to pick apart GRPC-specific code.
Put them in a separate '_generated_v2' subdir, to ease migration.

Attempt to factor generation process for clarity (toward #1482).
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2016
@tseaver tseaver changed the title Generate cod for Bigtable v2 protobufs Generate code for Bigtable v2 protobufs Jun 24, 2016
@daspecster

Copy link
Copy Markdown
Contributor

@tseaver & @dhermes is there anything specific I should keep an eye out for with these?

@tseaver

tseaver commented Jun 24, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster The code in the _generated_v2 package you can ignore. The other changes are attempts to improve how we generated code from protobufs (splitting up the Makefile, etc.)

@daspecster

Copy link
Copy Markdown
Contributor

Should datastore be in here with bigtable or should that be a separate PR?

@tseaver

tseaver commented Jun 24, 2016

Copy link
Copy Markdown
Contributor Author

The only thing I did with datastore was to factor its generate-from-protobuf bits into a separate Makefile.datastore. I ran the generation for it, and saw minor changes to the generated code, which I then discarded (not on my radar just now).

@daspecster

Copy link
Copy Markdown
Contributor

LGTM!

@tseaver tseaver merged commit e570b03 into googleapis:bigtable-v2 Jun 26, 2016
@tseaver tseaver deleted the bigtable-v2-regenerate_protobufs branch June 26, 2016 20:08
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Mar 2, 2026
Updates docstrings in `google/auth/transport/urllib3.py` to reference
`urllib3.PoolManager` instead of the removed/private
`urllib3.request.RequestMethods`, ensuring compatibility with `urllib3`
v2 documentation standards.

NOTE: This PR supercedes an [older PR
#1290](googleapis/google-auth-library-python#1290),
because some of the content or suggested changes in the older PR are
overtaken by events and/or been incorporated via [other recent
PRs](googleapis/google-auth-library-python#1389).

---
*PR created automatically by Jules for task
[17649723998293325458](https://jules.google.com/task/17649723998293325458)
started by @chalmerlowe*

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.1
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-auth: 2.46.0</summary>

##
[2.46.0](googleapis/google-auth-library-python@v2.45.0...v2.46.0)
(2026-01-05)

### Features

* Recognize workload certificate config in
has_default_client_cert_source for mTLS for Agentic Identities (#1907)
([0b9107d5](googleapis/google-auth-library-python@0b9107d5))

### Bug Fixes

* Fix test coverage for mtls_helper (#1886)
([02e71631](googleapis/google-auth-library-python@02e71631))

* use .read() instead of .content.read() in aiohttp transport (#1899)
([12f4470f](googleapis/google-auth-library-python@12f4470f))

* add types to default and verify_token and Request __init__ based on
comments in the source code. (#1588)
([59a5f588](googleapis/google-auth-library-python@59a5f588))

* fix the document of secure_authorized_session (#1536)
([5d001470](googleapis/google-auth-library-python@5d001470))

* raise RefreshError for missing token in impersonated credentials
(#1897)
([94d04e09](googleapis/google-auth-library-python@94d04e09))

* remove setup.cfg configuration for creating universal wheels (#1693)
([c767531c](googleapis/google-auth-library-python@c767531c))

### Documentation

* update urllib3 docstrings for v2 compatibility (#1903)
([3f1aeea2](googleapis/google-auth-library-python@3f1aeea2))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.