Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bigquery: loudly report invalid operations on dryruns#2772

Merged
pongad merged 2 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
pongad:bq-dryrunCopy head branch name to clipboard
Jan 16, 2018
Merged

bigquery: loudly report invalid operations on dryruns#2772
pongad merged 2 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
pongad:bq-dryrunCopy head branch name to clipboard

Conversation

@pongad

@pongad pongad commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

Fixes #2479.

@pongad pongad requested review from tswast and vam-google January 12, 2018 04:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2018

// Not "if (config.dryRun())", which fails if the Boolean is null.
// The below assumes that null means not-dryrun.
if (config.dryRun() == Boolean.TRUE) {

This comment was marked as spam.

@pongad pongad merged commit d629d3e into googleapis:master Jan 16, 2018
@pongad pongad deleted the bq-dryrun branch January 16, 2018 23:19
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
#2772)

* chore: Update generation configuration at Sat Nov 16 02:26:42 UTC 2024

* chore: generate libraries at Sat Nov 16 02:27:21 UTC 2024
suztomo pushed a commit that referenced this pull request Mar 9, 2026
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
This PR eliminates the need for:
 * `library_generation/owlbot/src/apply_repo_templates.py`
 * Passing the config yaml path to the postprocessing scripts

 ### How is it achieved?
 We set the environment variable `SYNTHTOOL_TEMPLATES` to point to a
 temp dir where we copy the contents of `owlbot/templates` plus a
 modification of the template using `sed` (instead of
 `synthtool.common_templates`). In this way, we avoid the usage of
 `apply_repo_templates.py`.
 generation_config.template_excludes.

 #### Why don't we use common_templates to pass libraries_bom_version?
 Because `owlbot.py` is a legacy script that was written when
 `java.common_templates` didn't take `libraries_bom_version` as a
 parameter. If we don't like this approach of having two template
 replacement workflows we could

 1. Modify all owlbot.py files
 2. Pass libraries_bom_version as an environment variable (not bad)

 #### What about template_excludes in the config yaml?
 We still need it to generate new libraries. This is done by rendering a
 new `owlbot.py` via templates.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
🤖 I have created a release *beep* *boop*
---


## [6.56.0](https://togithub.com/googleapis/java-spanner/compare/v6.55.0...v6.56.0) (2024-01-05)


### Features

* Add autoscaling config in the instance to support autoscaling in systests ([#2756](https://togithub.com/googleapis/java-spanner/issues/2756)) ([b0c36b5](https://togithub.com/googleapis/java-spanner/commit/b0c36b5148379f5debaf802aed3b0cca723b0a27))
* Add support for Directed Read options ([#2766](https://togithub.com/googleapis/java-spanner/issues/2766)) ([e97d4da](https://togithub.com/googleapis/java-spanner/commit/e97d4dac279b22760290e0aa4bc4816212b9ab31))
* Update OwlBot.yaml file to pull autogenerated executor code ([#2754](https://togithub.com/googleapis/java-spanner/issues/2754)) ([1093ba7](https://togithub.com/googleapis/java-spanner/commit/1093ba77658b3a592dd184284a324c0eea272851))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.21.0 ([#2772](https://togithub.com/googleapis/java-spanner/issues/2772)) ([8616fcf](https://togithub.com/googleapis/java-spanner/commit/8616fcf3c58d042520ed0dd2e6fb37cf3a9654cc))


### Documentation

* Samples and tests for auto-generated createDatabase and createInstance APIs. ([#2764](https://togithub.com/googleapis/java-spanner/issues/2764)) ([36837a4](https://togithub.com/googleapis/java-spanner/commit/36837a49b3b6e8401e956cb92f565af3fcc3e1a2))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
* chore: remove api-bigtable-partners

b/481375128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.