Fix typo in sample code (in javadoc)#2764
Closed
lama0206 wants to merge 2 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
lama0206:masterCopy head branch name to clipboard
Closed
Fix typo in sample code (in javadoc)#2764lama0206 wants to merge 2 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom lama0206:masterCopy head branch name to clipboard
lama0206 wants to merge 2 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
lama0206:masterCopy head branch name to clipboard
Conversation
Fix sample code in javadoc
Contributor
|
@lama0206 Thank you for the PR. Since this is in a generated file, I think we shouldn't fix it here since the change will get overwritten the next generation-cycle. I have filed googleapis/gapic-generator#1829 to track this issue. I'll close this PR in favor of fixing it at the root cause. |
Author
|
👍 |
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
* feat: Increase default Read API timeout to 60s * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
`isSynthetic()` is deprecated and will be [removed](protocolbuffers/protobuf@1aeacd4#diff-2228551d02c6661809ca7103db9512eef4c2d01f35556d42316543d92a89edefL2846-L2847) in protobuf-java 4.26.0, replace it so that we can prepare for protobuf-java upgrade. Per [official doc](https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md) of protobuf, an optional field is implemented as a "synthetic" oneof field internally. Also see b/266950618#comment123 for suggested replacements of `isSynthetic()`.
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.40.1</summary> ## [2.40.1](googleapis/sdk-platform-java@v2.40.0...v2.40.1) (2024-05-15) ### Bug Fixes * [common-protos] An existing method `UpdateVehicleLocation` is ([a8848b4](googleapis/sdk-platform-java@a8848b4)) * [common-protos] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2751](googleapis/sdk-platform-java#2751)) ([a8848b4](googleapis/sdk-platform-java@a8848b4)) * [iam] An existing method `UpdateVehicleLocation` is removed from ([04ab176](googleapis/sdk-platform-java@04ab176)) * [iam] An existing method `UpdateVehicleLocation` is removed from service `VehicleService` ([#2752](googleapis/sdk-platform-java#2752)) ([04ab176](googleapis/sdk-platform-java@04ab176)) * do not populate repo level change while removing library ([#2740](googleapis/sdk-platform-java#2740)) ([8d92d16](googleapis/sdk-platform-java@8d92d16)) * only append `.api.grpc` suffix to group id if the artifact id starts with `proto-` or `grpc-` ([#2731](googleapis/sdk-platform-java#2731)) ([b791c84](googleapis/sdk-platform-java@b791c84)) * opentelemetry-bom to be in third-party-dependencies BOM ([#2736](googleapis/sdk-platform-java#2736)) ([0700180](googleapis/sdk-platform-java@0700180)) * prepare to generate grafeas ([#2761](googleapis/sdk-platform-java#2761)) ([bf26ca1](googleapis/sdk-platform-java@bf26ca1)) * Replace deprecated protobuf methods. ([#2764](googleapis/sdk-platform-java#2764)) ([c1e586d](googleapis/sdk-platform-java@c1e586d)) ### Dependencies * update dependency black to v24.4.2 ([#2660](googleapis/sdk-platform-java#2660)) ([027191f](googleapis/sdk-platform-java@027191f)) * update dependency com.fasterxml.jackson:jackson-bom to v2.17.1 ([#2732](googleapis/sdk-platform-java#2732)) ([3e94c74](googleapis/sdk-platform-java@3e94c74)) * update dependency com.google.cloud:grpc-gcp to v1.6.0 ([#2767](googleapis/sdk-platform-java#2767)) ([e360a3d](googleapis/sdk-platform-java@e360a3d)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2708](googleapis/sdk-platform-java#2708)) ([5ceb5fa](googleapis/sdk-platform-java@5ceb5fa)) * update dependency com.google.errorprone:error_prone_annotations to v2.27.1 ([#2709](googleapis/sdk-platform-java#2709)) ([94df49f](googleapis/sdk-platform-java@94df49f)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.36.0 ([#2768](googleapis/sdk-platform-java#2768)) ([f8500df](googleapis/sdk-platform-java@f8500df)) * update dependency commons-codec:commons-codec to v1.17.0 ([#2710](googleapis/sdk-platform-java#2710)) ([d1c14e9](googleapis/sdk-platform-java@d1c14e9)) * update dependency jinja2 to v3.1.4 [security] ([#2742](googleapis/sdk-platform-java#2742)) ([e0ebded](googleapis/sdk-platform-java@e0ebded)) * update dependency lxml to v5.2.2 ([#2766](googleapis/sdk-platform-java#2766)) ([99e23f7](googleapis/sdk-platform-java@99e23f7)) * update dependency markupsafe to v2.1.5 ([#2657](googleapis/sdk-platform-java#2657)) ([834b258](googleapis/sdk-platform-java@834b258)) * update dependency net.bytebuddy:byte-buddy to v1.14.15 ([#2753](googleapis/sdk-platform-java#2753)) ([7494d67](googleapis/sdk-platform-java@7494d67)) * update dependency platformdirs to v4.2.1 ([#2662](googleapis/sdk-platform-java#2662)) ([9118e55](googleapis/sdk-platform-java@9118e55)) * update googleapis/java-cloud-bom digest to db4265f ([#2755](googleapis/sdk-platform-java#2755)) ([afbbb78](googleapis/sdk-platform-java@afbbb78)) * update googleapis/java-cloud-bom digest to f3c611a ([#2700](googleapis/sdk-platform-java#2700)) ([de5a108](googleapis/sdk-platform-java@de5a108)) * update opentelemetry-java monorepo to v1.38.0 ([#2769](googleapis/sdk-platform-java#2769)) ([74a2451](googleapis/sdk-platform-java@74a2451)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
…nstance APIs. (#2764) * fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests. * For details on issue see - googleapis/java-spanner#2206 * Fixing lint issues. * chore: adding a few samples with auto-gen clients. * chore: adding integration tests for samples. * chore: fixing the end-point for staging. * chore: modified test for CreateDatabaseWithDefaultLeaderSample. * chore: adding sample and integration test for CreateInstanceSample. * chore: adding license headers. * chore: fix lint errors. * chore: rename file and add sample tags. * chore: address comments. * Update samples/snippets/src/main/java/com/example/spanner/v2/CreateDatabaseWithDefaultLeaderSample.java Co-authored-by: Knut Olav Løite <koloite@gmail.com> * chore: rename file path. * chore: remove admin settings. * chore: address comments. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Knut Olav Løite <koloite@gmail.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- ## [6.56.0](https://togithub.com/googleapis/java-spanner/compare/v6.55.0...v6.56.0) (2024-01-05) ### Features * Add autoscaling config in the instance to support autoscaling in systests ([#2756](https://togithub.com/googleapis/java-spanner/issues/2756)) ([b0c36b5](https://togithub.com/googleapis/java-spanner/commit/b0c36b5148379f5debaf802aed3b0cca723b0a27)) * Add support for Directed Read options ([#2766](https://togithub.com/googleapis/java-spanner/issues/2766)) ([e97d4da](https://togithub.com/googleapis/java-spanner/commit/e97d4dac279b22760290e0aa4bc4816212b9ab31)) * Update OwlBot.yaml file to pull autogenerated executor code ([#2754](https://togithub.com/googleapis/java-spanner/issues/2754)) ([1093ba7](https://togithub.com/googleapis/java-spanner/commit/1093ba77658b3a592dd184284a324c0eea272851)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.21.0 ([#2772](https://togithub.com/googleapis/java-spanner/issues/2772)) ([8616fcf](https://togithub.com/googleapis/java-spanner/commit/8616fcf3c58d042520ed0dd2e6fb37cf3a9654cc)) ### Documentation * Samples and tests for auto-generated createDatabase and createInstance APIs. ([#2764](https://togithub.com/googleapis/java-spanner/issues/2764)) ([36837a4](https://togithub.com/googleapis/java-spanner/commit/36837a49b3b6e8401e956cb92f565af3fcc3e1a2)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
…#2764) BEGIN_COMMIT_OVERRIDE BEGIN_NESTED_COMMIT chore: update the Java code generator (gapic-generator-java) to 2.47.0 END_NESTED_COMMIT BEGIN_NESTED_COMMIT chore: update the libraries_bom version to 26.48.0 END_NESTED_COMMIT END_COMMIT_OVERRIDE * chore: remove extraneous release-please annotations --------- Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
rahul2393
pushed a commit
to akash329d/google-cloud-java
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a minor error in sample code contained in the javadoc of the v1/SpeechClient. Since this is generated, you might consider fixing it in the original source...