feat(spanner): add spanner::Value support for TypeCode::UUID #15076

devbww · Apr 9, 2025

This change is

scotthart · Apr 10, 2025

/gcbrun

codecov · Apr 10, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (7595793) to head (967c7cb).

Files with missing lines	Patch %	Lines
google/cloud/spanner/value.cc	87.50%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15076   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files        2389     2389           
  Lines      214832   214886   +54     
=======================================
+ Hits       199631   199693   +62     
+ Misses      15201    15193    -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

scotthart

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @devbww)

scotthart · Apr 10, 2025

Thanks again for the PR.

While the protos defining the UUID field are public, service support for the type isn't live yet. We'll merge this PR and write some integration tests when UUID is available in production.

devbww · Apr 10, 2025

While the protos defining the UUID field are public, service support for the type isn't live yet. We'll merge this PR and write some integration tests when UUID is available in production.

Okie dokie.

PiperOrigin-RevId: 745629297

…pis (googleapis#15075)

…apis#15071)

* feat(devicestreaming): generate library * Run generators and format their outputs * Add API baseline * Manually update READMEs, quickstart, and top-level stuff * changelog

…gleapis#15088)

…s#15087)

…gleapis#15077)

* fix: fix bug with customheadersoption * fix: fix bug with customheadersoption * fix: fix bug with customheadersoption * fix: fix bug with customheadersoption * fix: fix bug with customheadersoption * fix: fix bug with customheadersoption * fix: fix bug with customheadersoption --------- Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>

… in storage_object_samples (googleapis#15059) istream_iterator skips whitespace by default which results in data not being read as-is when it has whitespace symbols/bytes in it. Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>

* chore: update googleapis SHA circa 2025-04-16 PiperOrigin-RevId: 748054282

…googleapis#15100)

…oogleapis#15101)

* feat(chronicle): generate library * Run generators and format their outputs * Manually update READMEs, quickstart, and top-level stuff * Add API baseline * add endpoint option for quickstart

…gleapis#15094)

scotthart · Apr 28, 2025

/gcbrun

devbww · May 6, 2025

While the protos defining the UUID field are public, service support for the type isn't live yet. We'll merge this PR and write some integration tests when UUID is available in production.

I would proffer that this should be merged irrespective of the rollout of service support. It is the server support that actually matters, not the conversion between types within the client.

Also, merging now would mean that there is no need to wait for a new client release when server support is enabled. And that means client-side development can start early, including writing the integration tests, which can also actually be run against the staging service.

Finally, it avoids the possibility of future merge conflicts.

feat(spanner): add spanner::Value support for TypeCode::UUID

9ea1ae9

devbww requested a review from a team as a code owner April 9, 2025 21:33

product-auto-label bot added the api: spanner Issues related to the Spanner API. label Apr 9, 2025

devbww temporarily deployed to external April 10, 2025 17:28 — with GitHub Actions Inactive

scotthart previously approved these changes Apr 10, 2025

View reviewed changes

scotthart added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 10, 2025

cuiy0006 and others added 20 commits April 25, 2025 14:26

chore: update googleapis SHA circa 2025-04-09 (googleapis#15074)

eef4248

PiperOrigin-RevId: 745629297

cleanup: StorageBatchOperations comment changes introduced by googlea…

56142f7

…pis (googleapis#15075)

ci(gha): split shard and disable debug build for storage_grpc (google…

cdc8fbe

…apis#15071)

impl: add experimental client SSL certificate support (googleapis#15062)

2a57e04

feat(devicestreaming): generate library (googleapis#15079)

2d61aef

* feat(devicestreaming): generate library * Run generators and format their outputs * Add API baseline * Manually update READMEs, quickstart, and top-level stuff * changelog

impl: add experimental ca store in memory (googleapis#15068)

05fc5e4

impl: add experimental support for providing an SSL_CTX_FUNCTION (goo…

51cde37

…gleapis#15088)

impl: do not attempt to include openSSL headers in windows (googleapi…

9011f1a

…s#15087)

feat(spanner): add ISO8601 duration support to spanner::Interval (goo…

7403897

…gleapis#15077)

ci: split gha windows shard2 (googleapis#15091)

4eaba95

impl: prevent logging options from being overwritten (googleapis#15090)

78a9c3b

chore(compute): update discovery doc circa 20250415 (googleapis#15093)

e4ad24d

chore: update googleapis SHA circa 2025-04-16 (googleapis#15092)

cc3d1ed

* chore: update googleapis SHA circa 2025-04-16 PiperOrigin-RevId: 748054282

impl: add HttpHeader class (googleapis#15099)

438f655

ci: format compute service dirs bzl (googleapis#15098)

d362957

impl(rest): dedup and merge headers right before writing them to curl (…

b0905f9

…googleapis#15100)

build: leverage cmake and bazel to determine when to use OpenSSL API (g…

6619aff

…oogleapis#15101)

impl(generator): remove unused variable (googleapis#15103)

5813de4

cuiy0006 and others added 3 commits April 25, 2025 14:26

feat(chronicle): generate library (googleapis#15083)

e87d201

* feat(chronicle): generate library * Run generators and format their outputs * Manually update READMEs, quickstart, and top-level stuff * Add API baseline * add endpoint option for quickstart

ci: enable pedantic in clang-tidy builds (googleapis#15107)

dc9477d

feat(spanner): add spanner::Value support for TypeCode::INTERVAL (goo…

37af5a0

…gleapis#15094)

devbww requested a review from a team as a code owner April 25, 2025 18:37

Merge branch 'main' into uuid

967c7cb

devbww temporarily deployed to external April 28, 2025 14:54 — with GitHub Actions Inactive

devbww dismissed scotthart’s stale review via 967c7cb May 15, 2025 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(spanner): add spanner::Value support for TypeCode::UUID #15076

feat(spanner): add spanner::Value support for TypeCode::UUID #15076

Uh oh!

devbww commented Apr 9, 2025 •

edited by scotthart

Loading

Uh oh!

scotthart commented Apr 10, 2025

Uh oh!

codecov bot commented Apr 10, 2025 •

edited

Loading

Uh oh!

scotthart left a comment

Uh oh!

scotthart commented Apr 10, 2025

Uh oh!

devbww commented Apr 10, 2025

Uh oh!

scotthart commented Apr 28, 2025

Uh oh!

devbww commented May 6, 2025

Uh oh!

Uh oh!

Search code, repositories, users, issues, pull requests...

feat(spanner): add spanner::Value support for TypeCode::UUID #15076

Are you sure you want to change the base?

feat(spanner): add spanner::Value support for TypeCode::UUID #15076

Uh oh!

Conversation

devbww commented Apr 9, 2025 • edited by scotthart Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scotthart commented Apr 10, 2025

Uh oh!

codecov bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

scotthart left a comment

Choose a reason for hiding this comment

Uh oh!

scotthart commented Apr 10, 2025

Uh oh!

devbww commented Apr 10, 2025

Uh oh!

scotthart commented Apr 28, 2025

Uh oh!

devbww commented May 6, 2025

Uh oh!

Uh oh!

devbww commented Apr 9, 2025 •

edited by scotthart

Loading

codecov bot commented Apr 10, 2025 •

edited

Loading