feat(chronicle): generate library #15083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15083 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 2356 2356
Lines 210507 210507
=======================================
+ Hits 195575 195576 +1
+ Misses 14932 14931 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 172 files reviewed, all discussions resolved
devbww
pushed a commit
to devbww/google-cloud-cpp
that referenced
this pull request
Apr 25, 2025
* feat(chronicle): generate library * Run generators and format their outputs * Manually update READMEs, quickstart, and top-level stuff * Add API baseline * add endpoint option for quickstart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to specify endpoint option explicitly for quickstart, because its working endpoint is different from that provided by protos.
Quickstart returns response
Request contains an invalid argument, because we didn't create an instance, but it is an evidence that the service is reachable.This change is