impl: prevent logging options from being overwritten #15090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15090 +/- ##
==========================================
+ Coverage 92.86% 92.87% +0.01%
==========================================
Files 2356 2356
Lines 210713 210761 +48
==========================================
+ Hits 195675 195747 +72
+ Misses 15038 15014 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cuiy0006
reviewed
Apr 16, 2025
| EXPECT_FALSE(auth_options.has<LoggingComponentsOption>()); | ||
| } | ||
|
|
||
| TEST(MakeAuthOptions, WitLoggingComponents) { |
cuiy0006
approved these changes
Apr 16, 2025
devbww
pushed a commit
to devbww/google-cloud-cpp
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to specify a LoggingComponent option for logging the auth rpc flow, I discovered that the value I provided was being overwritten with the default values. This makes debugging hard. Adjusting the options flow to preserve user specified values for logging.
This change is