Make email name quoting more complete#99
Merged
dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom Nov 13, 2019
Merged
Make email name quoting more complete#99dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
Contributor
derrickstolee
left a comment
There was a problem hiding this comment.
Do you have a test to check the "Don't quote if already quoted" logic?
sunshineco
reviewed
Jun 28, 2019
sunshineco
left a comment
There was a problem hiding this comment.
I left some comments in the patch itself.
e152b61 to
e033210
Compare
Member
Author
Now I do ;-) |
According to https://tools.ietf.org/html/rfc2822#section-3.2.1, there are more special characters that require the name in an email address to be quoted. Pointed out by Eric Sunshine. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
e033210 to
dde3314
Compare
derrickstolee
approved these changes
Nov 13, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to address the shortcomings pointed out in #98 (comment).