Some style fixes#143
Merged
dscho merged 5 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom Nov 14, 2019
Merged
Some style fixes#143dscho merged 5 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
dscho merged 5 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
webstech
previously approved these changes
Nov 13, 2019
Contributor
webstech
left a comment
There was a problem hiding this comment.
Sorry about the let to const. I am not getting the linting errors in general in the test suite. Do you have a config change?
Member
Author
No worries.
TBH I do not even know what I did exactly to trigger this change. All I did was editing files in VS Code and minding my own business 😄 |
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Currently, this seems to be the only instance. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
Sorry for asking for another review; I had to resolve merge conflicts after merging #99 |
webstech
approved these changes
Nov 13, 2019
Member
Author
|
Thanks @webstech! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some random stuff, pointed out by cSpell and TSLint.