Quote names in emails if necessary#98
Quote names in emails if necessary#98dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
This is not actually legal in emails (even if such emails are accepted in many cases, vger.kernel.org does not): Cc: brian m. carlson <sandals@crustytoothpaste.net> Due to the `.`, the name needs to be quoted. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
@sunshineco could I ask you to review this? |
| }); | ||
|
|
||
| test("sender name with a dot in it is enclosed in double quotes", () => { | ||
| const withDots = "wile e. coyote <coyote@desert.net>"; |
|
Are we confident that only period is problematic in the name? My quick scan of RFC2822 §3.2.1 suggests that there are several other characters which might be problematic for vger. Why not take the simpler approach of quoting the name unconditionally rather than doing so only if it contains a period? (Or, perhaps quote it only if it does not already appear to be quoted -- by checking if the first character is a double quote.) Aside from the potential fragility of triggering only on period, the patch itself looks okay. |
That's a good point. I tried to address this in #99.
I really dislike unnecessary quoting. That would land you in quoting hell. :-) |
Hopefully this fixes the problem that prevented the mails from gitgitgadget/git#151 to be delivered correctly.
If only vger provided better diagnostics to us.