ref: Add internal sensitive-data denylist and key-value filter utility - #5440
#5440Draft
jamescrosswell wants to merge 1 commit into
maingetsentry/sentry-dotnet:mainfrom
feat/sensitive-data-filtergetsentry/sentry-dotnet:feat/sensitive-data-filterCopy head branch name to clipboard
Draft
ref: Add internal sensitive-data denylist and key-value filter utility#5440jamescrosswell wants to merge 1 commit intomaingetsentry/sentry-dotnet:mainfrom feat/sensitive-data-filtergetsentry/sentry-dotnet:feat/sensitive-data-filterCopy head branch name to clipboard
jamescrosswell wants to merge 1 commit into
maingetsentry/sentry-dotnet:mainfrom
feat/sensitive-data-filtergetsentry/sentry-dotnet:feat/sensitive-data-filterCopy head branch name to clipboard
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5440 +/- ##
==========================================
+ Coverage 74.58% 74.69% +0.10%
==========================================
Files 512 514 +2
Lines 18666 18747 +81
Branches 3659 3668 +9
==========================================
+ Hits 13922 14003 +81
Misses 3869 3869
Partials 875 875 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5421 (part of #5420).
First step of the DataCollection migration: adds the internal sensitive-terms denylist and the shared key-value filtering utility that later PRs will wire into header, cookie and query-string collection (#5422, #5423, #5424).
SensitiveDataFilter— canonical sensitive-key denylist from the spec (case-insensitive substring matching), cookie-name-only extra terms, GDPR/PII terms (for the futureSendDefaultPii=falsebridge, DataCollection phase 1: resolver and SendDefaultPii bridge #5426), andFilterKeyValueData/FilterValueimplementing the spec's filtering semantics: key names always preserved, sensitive values replaced with[Filtered].KeyValueFilterBehavior— internal off / denyList / allowList behavior (precursor to the public behavior type that ships with theDataCollectionoption, DataCollection phase 1: add option types (no-op) #5425). The built-in denylist always applies, including in allowList mode.Internal only — no public API change, and nothing is wired up yet, so no behavior change either. Mirrors
filterKeyValueData.ts/filtering-snippets.tsfrom the JS reference implementation (getsentry/sentry-javascript#20965, getsentry/sentry-javascript#20989) so the two SDKs filter identically.#skip-changelog
🤖 Generated with Claude Code