Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DataCollection phase 0: always redact sensitive header values #5422

Copy link
Copy link

Description

@jamescrosswell
Issue body actions

Part of #5420. Phase 0 — hardening pre-work, no new public API.

Today only Authorization and Proxy-Authorization header values are redacted (src/Sentry/Internal/RedactedHeaders.cs, SentryRequest.AddHeaders, Protocol/Response.AddHeaders), and only in some paths. Apply the full sensitive-terms denylist filter to header values unconditionally — regardless of SendDefaultPii — in:

  • src/Sentry/SentryRequest.cs / src/Sentry/Protocol/Response.cs (AddHeaders)
  • src/Sentry.AspNetCore/ScopeExtensions.cs (request header capture)
  • src/Sentry.AspNet/Internal/SystemWebRequestEventProcessor.cs
  • src/Sentry/SentryHttpFailedRequestHandler.cs / SentryGraphQLHttpFailedRequestHandler.cs

Key names are kept; values become [Filtered]. Depends on the denylist/filter utility issue.

JS reference: getsentry/sentry-javascript#18311 (shipped standalone in 10.27.0, well before the option existed).

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.