Conditionalize all of the CsWin32 related interop for the source build - #52788
#52788Merged
Merged
Conditionalize all of the CsWin32 related interop for the source build#52788
Conversation
JeremyKuhne
requested review from
baronfel and
Copilot
and removed request for
Copilot
February 2, 2026 21:24
Contributor
There was a problem hiding this comment.
Pull request overview
This PR conditionalizes CsWin32-related interop code for source builds by excluding Windows-specific files when DotNetBuildSourceOnly is set to true.
Changes:
- Reorganizes source build exclusions into a dedicated ItemGroup
- Adds exclusion of Windows/** and Microsoft/VisualStudio/** directories for source builds
Member
Author
|
The project now builds with |
ViktorHofer
approved these changes
Feb 2, 2026
JeremyKuhne
enabled auto-merge (rebase)
February 2, 2026 21:33
NikolaMilosavljevic
approved these changes
Feb 2, 2026
MiYanni
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/dotnet#4471