[main] Source code updates from dotnet/sdk - #4471
#4471[main] Source code updates from dotnet/sdk#4471dotnet-maestro[bot] wants to merge 11 commits intomaindotnet/dotnet:mainfrom darc-main-86863c85-13bf-4ebb-8d41-d7b756416c96dotnet/dotnet:darc-main-86863c85-13bf-4ebb-8d41-d7b756416c96Copy head branch name to clipboard
Conversation
Diff: https://github.com/dotnet/sdk/compare/701f7951f86c4e4d79ee9be0c22fd929961f61ff..36dadfe1b1c89584429e2d9c0a9c1c7fa0205b99 From: dotnet/sdk@701f795 To: dotnet/sdk@36dadfe [[ commit created by automation ]]
Diff: https://github.com/dotnet/sdk/compare/36dadfe1b1c89584429e2d9c0a9c1c7fa0205b99..bb7a82d677c1b8e9937c5d7e6ac1303ca00de0f7 From: dotnet/sdk@36dadfe To: dotnet/sdk@bb7a82d [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/sdk/compare/bb7a82d677c1b8e9937c5d7e6ac1303ca00de0f7..d97428fd4cff41ca381b487a97bfe14cde2efd76 From: dotnet/sdk@bb7a82d To: dotnet/sdk@d97428f [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/sdk/compare/d97428fd4cff41ca381b487a97bfe14cde2efd76..b3dc9134cda13de80fbd8c4e68fab657df83b412 From: dotnet/sdk@d97428f To: dotnet/sdk@b3dc913 [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
@JeremyKuhne looks like your change dotnet/sdk#52650 breaks source-build. You probably want to exclude the new files in dotnet.csproj when building source-only. |
I'm not completely surprised. I'll try and get this fixed asap. If there are any guidelines on how to vet that you won't break source build, I'd appreciate any links. :) |
|
@dotnet/product-construction Can we just use the CsWin32 source generator in the mono repo? WinForms and WPF depend on it, but I'm unclear on if those builds are fully enabled here. (I can easily make things build if I exclude the Windows code paths when building here in places we do runtime checks, but I'm not sure that is the right answer.) |
|
No, cswin32 isn't part of the VMR and therefore not source-buildable. Why would you want to use cswin32 (which is Windows specific) when building the product from source for Unix platforms? |
I don't have to if we're not expecting binaries to come out of here that will run (correctly) on Windows. I see that we have Windows legs, but we can't be getting fully working binaries as some of the Windows specific runtime I want to make sure I do the right thing both for the current state and be thinking about / prepared for future state of this repo. |
|
The source-build job produces artifacts that only run on Unix platforms, never on Windows. Source-build has more restrictions: no prebuilts, no internet connection for a stage2 build, etc. The Windows jobs use whatever set-up you have enabled in the original repository -> dotnet/sdk. If you use cswin32 as a packagerefernce, it will just use that. The VMR doesn't do anything differently here than the individual repository build. That's why the Windows jobs here are passing. The crux here is that the sdk repository currently doesn't have a VMR source-only job enabled in their CI. We should add one, cc @MichaelSimons @marcpopMSFT to detect such issues at PR time. |
|
@ViktorHofer so Windows builds here do not set |
Diff: https://github.com/dotnet/sdk/compare/b3dc9134cda13de80fbd8c4e68fab657df83b412..e11e478f952ab13db71debfa35f8bfcc763c31b1 From: dotnet/sdk@b3dc913 To: dotnet/sdk@e11e478 [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Per offline conversation, we believe the right compromise is to enable on-demand VMR builds from SDK PRs. I'm told that's possible and Nikola has done it before so filed the issue and assigned to him: dotnet/sdk#52838 |
Note
This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/sdk
Diff the source with this PR branch