Bring a few jithelpers to new unwind plan - #123307
#123307Merged
janvorli merged 21 commits intoJan 22, 2026
dotnet:maindotnet/runtime:mainfrom
am11:feature/deterministic-unwindingam11/runtime:feature/deterministic-unwindingCopy head branch name to clipboard
Merged
Bring a few jithelpers to new unwind plan#123307janvorli merged 21 commits intodotnet:maindotnet/runtime:mainfrom am11:feature/deterministic-unwindingam11/runtime:feature/deterministic-unwindingCopy head branch name to clipboard
janvorli merged 21 commits into
dotnet:maindotnet/runtime:mainfrom
am11:feature/deterministic-unwindingam11/runtime:feature/deterministic-unwindingCopy head branch name to clipboard
Conversation
jkoritzinsky
left a comment
Member
There was a problem hiding this comment.
Can you add calls to __asan_no_return on all the paths that don't return and don't go through RtlRestoreContext any more?
This was referenced Jan 17, 2026
Member
Author
They go through |
This was referenced Jan 18, 2026
am11
marked this pull request as ready for review
January 18, 2026 14:03
Member
I've forgotten to remove it when I moved the functionality into the InterpreterCodeManager::ResumeAfterCatch. |
janvorli
reviewed
Jan 19, 2026
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Failures seem to be unrelated. linux*: tracing test missing some user-event (#122430) |
Member
Member
Author
janvorli
reviewed
Jan 22, 2026
This was referenced Jan 26, 2026
This was referenced Jan 27, 2026
jkotas
added a commit
that referenced
this pull request
Jan 28, 2026
jkotas
added a commit
to jkotas/runtime
that referenced
this pull request
Jan 28, 2026
…plan (dotnet#123307)" This reverts commit 18acc2d.
4 tasks
jkotas
added a commit
that referenced
this pull request
Jan 28, 2026
…plan (#123307)" (#123715) Backport of #123696 to release/11.0-preview1 /cc @janvorli ## Customer Impact - [ ] Customer reported - [x] Found internally Very frequent intermittent runtime crashes caused by buggy CPU context manipulations. ## Regression - [x] Yes - [ ] No Regression introduced by #123307, merged on Thu Jan 22, 2026. ## Testing Default CI run. ## Risk Low, clean revert of the offending PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnwindAndContinueResumeAfterCatch, which seems unused; can be brought back with new plan based on the use-case / contextual info (need to double-check with @janvorli).