Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revisit EH at P/Invoke boundary for QCalls #123482

Copy link
Copy link

Description

@am11
Issue body actions

we don't push them on pinvoke boundary for perf reason (@jkotas believed the perf hit would not be acceptable

On Unix, we would have to get rid of the internal EH interop for QCalls to do this correctly: catch the exception on QCall unmanaged side, store it in a thread local variable or in an [out] argument register, and rethrow it on the managed size.

Also, we would have the do something about the other managed->unmanaged transitions that do not go through the regular PInvoke path. For the less perf-sensitive transitions like ThePreStub, it should be ok to push the callee saved float registers.

Originally posted by @jkotas in #123307 (comment)

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status
    No status
    Show more project fields

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.