[release/9.0] Fixing 0 length issue with constructor - #107881
#107881Merged
ericstj merged 3 commits intoSep 16, 2024
release/9.0dotnet/runtime:release/9.0from
backport/pr-107427-to-release/9.0dotnet/runtime:backport/pr-107427-to-release/9.0Copy head branch name to clipboard
Merged
[release/9.0] Fixing 0 length issue with constructor#107881ericstj merged 3 commits intorelease/9.0dotnet/runtime:release/9.0from backport/pr-107427-to-release/9.0dotnet/runtime:backport/pr-107427-to-release/9.0Copy head branch name to clipboard
ericstj merged 3 commits into
release/9.0dotnet/runtime:release/9.0from
backport/pr-107427-to-release/9.0dotnet/runtime:backport/pr-107427-to-release/9.0Copy head branch name to clipboard
Conversation
…ors/netcore/ReadOnlyTensorSpan.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
artl93
approved these changes
Sep 16, 2024
3 tasks
Contributor
|
/ba-g The single test failure is a known test failure not related to these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107427 to release/9.0
/cc @michaelgsharp
Customer Impact
Fixes #106538 by modifying the check in the constructor to also throw an error if the base memory length is 0. Before if the length was 0 it wouldn't do some additional checks because it would never actually access the underlying memory. This caused some interesting behaviors. This fixes that so all those additional checks are now always performed.
Regression
Testing
Additional automated testing was added to test this specific behavior and scenario. It was missed before as its only caused by an interesting edge case.
Risk
Low risk. Tensor is going to be a preview release and was added in this 9.0 release.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.